diff --git a/pom.xml b/pom.xml index a161e4186..85213860f 100644 --- a/pom.xml +++ b/pom.xml @@ -76,6 +76,10 @@ io.jenkins.plugins caffeine-api + + io.jenkins.plugins + commons-lang3-api + org.jenkins-ci.plugins authentication-tokens diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java index ac8a09213..75abc1edb 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/ContainerTemplate.java @@ -16,7 +16,7 @@ import java.util.Objects; import java.util.TreeMap; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.model.TemplateEnvVar; import org.jenkinsci.Symbol; import org.kohsuke.accmod.Restricted; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java index e598a75ee..ef262b6a0 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java @@ -1,7 +1,7 @@ package org.csanchez.jenkins.plugins.kubernetes; import static java.nio.charset.StandardCharsets.UTF_8; -import static org.apache.commons.lang.StringUtils.isEmpty; +import static org.apache.commons.lang3.StringUtils.isEmpty; import static org.csanchez.jenkins.plugins.kubernetes.PodTemplateUtils.sanitizeLabel; import com.cloudbees.plugins.credentials.CredentialsMatchers; @@ -76,7 +76,7 @@ import jenkins.util.SystemProperties; import jenkins.websocket.WebSockets; import net.sf.json.JSONObject; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateMap; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.Default; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.PodRetention; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java index a679b02a7..e5e6db5ea 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java @@ -29,7 +29,7 @@ import java.util.logging.Logger; import jenkins.model.Jenkins; import org.acegisecurity.Authentication; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuthException; import org.kohsuke.stapler.QueryParameter; import org.kohsuke.stapler.StaplerRequest2; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java index e23467d9f..5242da08b 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesFactoryAdapter.java @@ -24,7 +24,7 @@ import java.util.logging.Logger; import jenkins.authentication.tokens.api.AuthenticationTokens; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuth; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuthConfig; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuthException; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java index 841601dab..93ca03fdd 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java @@ -55,7 +55,7 @@ import java.util.stream.Collectors; import jenkins.metrics.api.Metrics; import jenkins.util.SystemProperties; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.pod.decorator.PodDecoratorException; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.Reaper; import org.kohsuke.stapler.DataBoundConstructor; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesSlave.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesSlave.java index 601514b73..654ff8375 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesSlave.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesSlave.java @@ -46,8 +46,8 @@ import jenkins.metrics.api.Metrics; import jenkins.model.Jenkins; import jenkins.security.MasterToSlaveCallable; -import org.apache.commons.lang.StringUtils; -import org.apache.commons.lang.Validate; +import org.apache.commons.lang3.StringUtils; +import org.apache.commons.lang3.Validate; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.PodRetention; import org.jenkinsci.plugins.durabletask.executors.OnceRetentionStrategy; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuthException; @@ -260,7 +260,7 @@ public FilePath getRootPath() { // if computer is null then channel is null and thus we were going to return null anyway return null; } else { - return createPath(StringUtils.defaultString(computer.getAbsoluteRemoteFs(), getRemoteFS())); + return createPath(Objects.toString(computer.getAbsoluteRemoteFs(), getRemoteFS())); } } diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodContainerSource.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodContainerSource.java index 83bb1e15f..08e3b9b17 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodContainerSource.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodContainerSource.java @@ -12,7 +12,7 @@ import java.util.List; import java.util.Objects; import java.util.Optional; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; /** * Pod container sources are responsible to locating details about Pod containers. diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodLabel.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodLabel.java index 333901f47..5569bb909 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodLabel.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodLabel.java @@ -13,7 +13,7 @@ import java.util.List; import java.util.Map; import java.util.Objects; -import org.apache.commons.lang.Validate; +import org.apache.commons.lang3.Validate; import org.jenkinsci.Symbol; import org.kohsuke.stapler.DataBoundConstructor; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java index ae43d991b..22be46654 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java @@ -39,7 +39,7 @@ import java.util.logging.Logger; import jenkins.model.Jenkins; import net.sf.json.JSONObject; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.model.TemplateEnvVar; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.PodRetention; import org.csanchez.jenkins.plugins.kubernetes.pod.yaml.YamlMergeStrategy; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java index 622d79b1a..44ff210e0 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java @@ -63,6 +63,7 @@ import java.util.HashMap; import java.util.List; import java.util.Map; +import java.util.Objects; import java.util.Optional; import java.util.logging.Level; import java.util.logging.Logger; @@ -71,7 +72,7 @@ import java.util.stream.Collectors; import jenkins.model.Jenkins; import jenkins.util.SystemProperties; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.model.TemplateEnvVar; import org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStepExecution; import org.csanchez.jenkins.plugins.kubernetes.pod.decorator.PodDecorator; @@ -308,7 +309,7 @@ public Pod build() { } // default agent container - String agentContainerName = StringUtils.defaultString(template.getAgentContainer(), JNLP_NAME); + String agentContainerName = Objects.toString(template.getAgentContainer(), JNLP_NAME); Optional agentOpt = pod.getSpec().getContainers().stream() .filter(c -> agentContainerName.equals(c.getName())) .findFirst(); diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtils.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtils.java index ac5b98c90..752dd8af5 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtils.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateUtils.java @@ -53,7 +53,7 @@ import java.util.regex.Pattern; import java.util.stream.Collectors; import java.util.stream.Stream; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.apache.tools.ant.types.Commandline; import org.csanchez.jenkins.plugins.kubernetes.model.TemplateEnvVar; import org.csanchez.jenkins.plugins.kubernetes.volumes.PodVolume; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodUtils.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodUtils.java index bea03d816..aac04ea79 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodUtils.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodUtils.java @@ -38,8 +38,8 @@ import java.util.regex.Pattern; import java.util.stream.Collectors; import jenkins.model.Jenkins; -import org.apache.commons.lang.RandomStringUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.pipeline.PodTemplateStepExecution; public final class PodUtils { @@ -208,7 +208,7 @@ public static String logLastLines(@NonNull Pod pod, @NonNull KubernetesClient cl */ @NonNull public static String generateRandomSuffix() { - return RandomStringUtils.random(5, "bcdfghjklmnpqrstvwxz0123456789"); + return RandomStringUtils.secure().next(5, "bcdfghjklmnpqrstvwxz0123456789"); } /** diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesDeclarativeAgent.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesDeclarativeAgent.java index 1c2c8f327..7c5dc7c73 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesDeclarativeAgent.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/KubernetesDeclarativeAgent.java @@ -17,7 +17,7 @@ import java.util.logging.Level; import java.util.logging.Logger; import java.util.stream.Collectors; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate; import org.csanchez.jenkins.plugins.kubernetes.PodTemplate; import org.csanchez.jenkins.plugins.kubernetes.pod.retention.PodRetention; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java index 55ddc3819..8783a0f18 100755 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStep.java @@ -18,7 +18,7 @@ import java.util.Set; import java.util.stream.Collectors; import jenkins.model.Jenkins; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate; import org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud; import org.csanchez.jenkins.plugins.kubernetes.PodAnnotation; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java index f18515b7f..6bcdc4688 100755 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateStepExecution.java @@ -19,7 +19,6 @@ import java.util.logging.Level; import java.util.logging.Logger; import jenkins.model.Jenkins; -import org.apache.commons.lang.RandomStringUtils; import org.csanchez.jenkins.plugins.kubernetes.ContainerTemplate; import org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud; import org.csanchez.jenkins.plugins.kubernetes.KubernetesFolderProperty; @@ -28,6 +27,7 @@ import org.csanchez.jenkins.plugins.kubernetes.PodImagePullSecret; import org.csanchez.jenkins.plugins.kubernetes.PodTemplate; import org.csanchez.jenkins.plugins.kubernetes.PodTemplateUtils; +import org.csanchez.jenkins.plugins.kubernetes.PodUtils; import org.jenkinsci.plugins.workflow.steps.AbstractStepExecutionImpl; import org.jenkinsci.plugins.workflow.steps.BodyExecutionCallback; import org.jenkinsci.plugins.workflow.steps.BodyInvoker; @@ -75,8 +75,8 @@ public boolean start() throws Exception { String label; String podTemplateLabel = step.getLabel(); if (podTemplateLabel == null) { - var sanitized = PodTemplateUtils.sanitizeLabel(run.getExternalizableId()) + "-" - + RandomStringUtils.random(5, "bcdfghjklmnpqrstvwxz0123456789"); + var sanitized = + PodTemplateUtils.sanitizeLabel(run.getExternalizableId()) + "-" + PodUtils.generateRandomSuffix(); assert PodTemplateUtils.validateLabel(sanitized) : sanitized; label = sanitized; } else { @@ -85,7 +85,7 @@ public boolean start() throws Exception { // Let's generate a random name based on the user specified to make sure that we don't have // issues with concurrent builds, or messing with pre-existing configuration - String randString = RandomStringUtils.random(5, "bcdfghjklmnpqrstvwxz0123456789"); + String randString = PodUtils.generateRandomSuffix(); String stepName = step.getName(); if (stepName == null) { stepName = label; diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pod/decorator/DefaultRestartPolicy.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pod/decorator/DefaultRestartPolicy.java index 495742544..c19f2c77a 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pod/decorator/DefaultRestartPolicy.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/pod/decorator/DefaultRestartPolicy.java @@ -3,7 +3,7 @@ import edu.umd.cs.findbugs.annotations.NonNull; import hudson.Extension; import io.fabric8.kubernetes.api.model.Pod; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud; /** diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/ProvisionedVolume.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/ProvisionedVolume.java index 1da524983..0da3a1ed3 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/ProvisionedVolume.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/ProvisionedVolume.java @@ -3,7 +3,7 @@ import io.fabric8.kubernetes.api.model.Quantity; import java.util.Collections; import java.util.Map; -import org.apache.commons.lang.StringUtils; +import java.util.Objects; public interface ProvisionedVolume { default String getStorageClassNameOrDefault() { @@ -17,13 +17,13 @@ default Map getResourceMap() { } default String getRequestsSizeOrDefault() { - return StringUtils.defaultString(getRequestsSize(), "10Gi"); + return Objects.toString(getRequestsSize(), "10Gi"); } String getRequestsSize(); default String getAccessModesOrDefault() { - return StringUtils.defaultString(getAccessModes(), "ReadWriteOnce"); + return Objects.toString(getAccessModes(), "ReadWriteOnce"); } String getAccessModes(); diff --git a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/SecretVolume.java b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/SecretVolume.java index c71b7ff30..f7a2bbbcd 100644 --- a/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/SecretVolume.java +++ b/src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/SecretVolume.java @@ -30,7 +30,7 @@ import io.fabric8.kubernetes.api.model.SecretVolumeSource; import io.fabric8.kubernetes.api.model.Volume; import io.fabric8.kubernetes.api.model.VolumeBuilder; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.Symbol; import org.kohsuke.stapler.DataBoundConstructor; diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesTestUtil.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesTestUtil.java index 590bdb90f..401bbd823 100644 --- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesTestUtil.java +++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesTestUtil.java @@ -59,7 +59,7 @@ import jenkins.model.Jenkins; import jenkins.model.JenkinsLocationConfiguration; import org.apache.commons.io.IOUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.jenkinsci.plugins.kubernetes.auth.KubernetesAuthException; import org.jenkinsci.plugins.workflow.cps.CpsFlowDefinition; import org.jenkinsci.plugins.workflow.job.WorkflowJob; diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodUtilsTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodUtilsTest.java index b7ff7e66f..01695801c 100644 --- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodUtilsTest.java +++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/PodUtilsTest.java @@ -8,7 +8,7 @@ import java.util.List; import java.util.Set; import java.util.stream.IntStream; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.junit.Test; public class PodUtilsTest { diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/AbstractKubernetesPipelineRJRTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/AbstractKubernetesPipelineRJRTest.java index 6a9d862a4..789f890de 100644 --- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/AbstractKubernetesPipelineRJRTest.java +++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/AbstractKubernetesPipelineRJRTest.java @@ -2,7 +2,7 @@ import static org.csanchez.jenkins.plugins.kubernetes.KubernetesTestUtil.assumeKubernetes; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.KubernetesTestUtil; import org.csanchez.jenkins.plugins.kubernetes.pipeline.steps.CreateWorkflowJobThenScheduleRun; import org.csanchez.jenkins.plugins.kubernetes.pipeline.steps.RunId; diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorTest.java index 937e20aec..1ecf8d647 100644 --- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorTest.java +++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorTest.java @@ -63,12 +63,12 @@ import java.util.logging.Logger; import java.util.regex.Pattern; import org.apache.commons.io.output.TeeOutputStream; -import org.apache.commons.lang.RandomStringUtils; -import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang3.StringUtils; import org.csanchez.jenkins.plugins.kubernetes.KubernetesClientProvider; import org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud; import org.csanchez.jenkins.plugins.kubernetes.KubernetesSlave; import org.csanchez.jenkins.plugins.kubernetes.PodTemplate; +import org.csanchez.jenkins.plugins.kubernetes.PodUtils; import org.jenkinsci.plugins.workflow.steps.StepContext; import org.junit.After; import org.junit.Before; @@ -126,7 +126,7 @@ public void configureCloud() throws Exception { deletePods(client, getLabels(this, name), false); String image = "busybox"; - String podName = "test-command-execution-" + RandomStringUtils.random(5, "bcdfghjklmnpqrstvwxz0123456789"); + String podName = PodUtils.createNameWithRandomSuffix("test-command-execution"); pod = client.pods() .create(new PodBuilder() .withNewMetadata() diff --git a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorWindowsTest.java b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorWindowsTest.java index 4dd73abe8..ef76816be 100644 --- a/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorWindowsTest.java +++ b/src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/ContainerExecDecoratorWindowsTest.java @@ -56,11 +56,11 @@ import java.util.logging.Logger; import java.util.regex.Pattern; import org.apache.commons.io.output.TeeOutputStream; -import org.apache.commons.lang.RandomStringUtils; import org.csanchez.jenkins.plugins.kubernetes.KubernetesClientProvider; import org.csanchez.jenkins.plugins.kubernetes.KubernetesCloud; import org.csanchez.jenkins.plugins.kubernetes.KubernetesSlave; import org.csanchez.jenkins.plugins.kubernetes.PodTemplate; +import org.csanchez.jenkins.plugins.kubernetes.PodUtils; import org.jenkinsci.plugins.workflow.steps.StepContext; import org.junit.After; import org.junit.Before; @@ -110,7 +110,7 @@ public void configureCloud() throws Exception { String image = "mcr.microsoft.com/windows:" + WINDOWS_1809_BUILD + ".2686"; String containerName = "container"; - String podName = "test-command-execution-" + RandomStringUtils.random(5, "bcdfghjklmnpqrstvwxz0123456789"); + String podName = PodUtils.createNameWithRandomSuffix("test-command-execution"); pod = client.pods() .create(new PodBuilder() .withNewMetadata()