Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling, check for HTTP status codes in GenericCRUD and derivatives #14

Open
adityasaky opened this issue May 12, 2020 · 0 comments

Comments

@adityasaky
Copy link
Collaborator

The code snippet used in GenericCRUD to send the actual HTTP request was written for a proof-of-concept, and needs to be fleshed out, with better error handling.

This snippet is also used in the Etcd and Grafeas transports, currently.

/* FIXME: should handle error codes and other situations more appropriately,
* but this gets the job done for a PoC
*/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant