Skip to content

[JENKINS-50520] Stop shading jclouds, update to 2.1.0, fix Guice & Guava issues #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
carlossg merged 5 commits into from
Jun 7, 2018
Merged

[JENKINS-50520] Stop shading jclouds, update to 2.1.0, fix Guice & Guava issues #44

carlossg merged 5 commits into from
Jun 7, 2018

Conversation

@jglick
Copy link
Member

@jglick jglick commented Jun 6, 2018

JENKINS-50520

Adds a dep on jenkinsci/workflow-cps-plugin#231.

Besides automated tests, I tried mvn hpi:run and also running in java -jar jenkins.war mode.

@jglick jglick requested review from carlossg and kuisathaverat June 6, 2018 19:27
@jglick
Copy link
Member Author

jglick commented Jun 6, 2018

Oops, need to wait for upstream to deploy.

@jglick jglick closed this Jun 6, 2018
@jglick jglick reopened this Jun 6, 2018
@jglick
Copy link
Member Author

jglick commented Jun 6, 2018

The other CI build did pass; for some reason, the CI server reporting the build failure processed the close event but not the open event.

carlossg
carlossg previously requested changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorCleaning test is failing, probably it was assuming something that changed with guava version

@jglick
Copy link
Member Author

jglick commented Jun 7, 2018

Seems to be some sort of interference with #42 but not clear what. Will investigate.

@jglick
Copy link
Member Author

jglick commented Jun 7, 2018

Ah:

java.lang.NoSuchMethodError: com.google.common.collect.Iterators.skip(Ljava/util/Iterator;I)I
	at hudson.util.RunList.subList(RunList.java:153)
	at hudson.tasks.LogRotator.perform(LogRotator.java:153)
	at hudson.model.Job.logRotate(Job.java:468)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.lambda$finish$1(WorkflowRun.java:812)
	at …

Looks like I may need a core patch for this, TBD.

@jglick
Copy link
Member Author

jglick commented Jun 7, 2018

Filed jenkinsci/jenkins#3481 but it only affects test code so I am just skipping that part of the test for now.

@jglick jglick requested a review from carlossg June 7, 2018 17:00
@carlossg carlossg merged commit 0d2d183 into master Jun 7, 2018
@carlossg carlossg deleted the jclouds-JENKINS-50520 branch June 7, 2018 17:14
@jglick jglick mentioned this pull request Jul 9, 2018
Merged
@jglick jglick mentioned this pull request Aug 29, 2018
Merged
@jglick jglick mentioned this pull request Oct 4, 2018
Closed
@jglick jglick mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@carlossg carlossg carlossg approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jglick @carlossg @kuisathaverat