Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade aws tf provider to 4 #352

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

ankitm123
Copy link
Member

@ankitm123 ankitm123 commented Jul 1, 2022

Signed-off-by: ankitm123 [email protected]

Description

Upgrade tf provider to 4.0+ and remove all deprecations in the module because of the upgrade.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #339

Release notes

@ankitm123
Copy link
Member Author

ankitm123 commented Jul 1, 2022

Works in my test cluster, without any issues, but would be good to have a few testers.

Tested in my cluster using (comment out source and version in ur main.tf):

source                           = "github.com/ankitm123/terraform-aws-eks-jx?ref=ankitm123.tf-aws-4"

Run:

  • terraform init -upgrade
  • terraform plan

In my cluster this is what I get:

Plan: 8 to add, 1 to change, 1 to destroy.

The destroy is unrelated to these changes.

@ankitm123 ankitm123 requested a review from msvticket July 1, 2022 18:58
@ankitm123 ankitm123 marked this pull request as draft July 1, 2022 19:02
@ankitm123 ankitm123 force-pushed the ankitm123.tf-aws-4 branch from 6e32fa8 to f43096e Compare July 1, 2022 19:24
@ankitm123 ankitm123 requested a review from babadofar July 6, 2022 19:58
@ankitm123 ankitm123 marked this pull request as ready for review July 7, 2022 10:31
@babadofar
Copy link
Contributor

babadofar commented Jul 8, 2022

Confirm that this works, on my cluster which has not been updated since version 1.15
/approve

@ankitm123 ankitm123 merged commit 740dcb5 into jenkins-x:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade aws provider to 4
2 participants