Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisioned IAM policy for Secrets Manager does not include ListSecrets action #327

Closed
stemurray opened this issue Nov 26, 2021 · 1 comment · Fixed by #328
Closed

Provisioned IAM policy for Secrets Manager does not include ListSecrets action #327

stemurray opened this issue Nov 26, 2021 · 1 comment · Fixed by #328

Comments

@stemurray
Copy link
Contributor

Summary

When using AWS Secrets Manager, the "data.aws_iam_policy_document.secrets-manager-policy" block in ./modules/cluster.irsa.tf includes the "secretsmanager:ListSecrets" action in a group of actions that have resource constraints. But "secretsmanager:ListSecrets" cannot have resource constraints, so it is not included in the policy.

Steps to reproduce the behaviour

set use_vault variable to false
sert use_asm variable to true
set create_asm_role variable to true
terraform apply

Expected behavior

Policy created which includes "secretsmanager:ListSecrets" action

Actual behavior

Policy created does not include "secretsmanager:ListSecrets" action

Terraform version

The output of terraform version is:

Terraform v1.0.11
on linux_amd64

Module version

1.18.1

Operating system

Linux (Ubuntu 20.04)
@stemurray
Copy link
Contributor Author

I have a fix for this and will open a pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant