Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variable to set boot secrets #325

Merged
merged 1 commit into from
Nov 11, 2021
Merged

feat: add variable to set boot secrets #325

merged 1 commit into from
Nov 11, 2021

Conversation

ankitm123
Copy link
Member

Signed-off-by: ankitm123 [email protected]

Description

This PR adds a boot_secret variable which can set some env variables during the boot process to make working with external vault more convenient.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #324

@ankitm123 ankitm123 merged commit 6c42f2e into jenkins-x:master Nov 11, 2021
type = string
}))
default = []
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no, EOL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add external_vault and vault_url to jx-boot-job-env-vars secret
1 participant