Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external_vault and vault_url to jx-boot-job-env-vars secret #324

Closed
ankitm123 opened this issue Nov 8, 2021 · 0 comments · Fixed by #325
Closed

Add external_vault and vault_url to jx-boot-job-env-vars secret #324

ankitm123 opened this issue Nov 8, 2021 · 0 comments · Fixed by #325
Assignees

Comments

@ankitm123
Copy link
Member

Summary

For external vault, end users have to manually set EXTERNAL_VAULT = true and VAULT_URL = in the version stream makefile.

The issue with this is that every time they run jx gitops upgrade, the make file will get over written.

What we can do instead is set those values in the jx-boot-job-env-vars secret in the jx-git-operator namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant