Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 bucket still created when storage is disabled #321

Closed
msvticket opened this issue Nov 4, 2021 · 0 comments · Fixed by #322
Closed

S3 bucket still created when storage is disabled #321

msvticket opened this issue Nov 4, 2021 · 0 comments · Fixed by #322

Comments

@msvticket
Copy link
Member

msvticket commented Nov 4, 2021

Summary

If a storage is disabled by setting either of enable_logs_storage, enable_reports_storage or enable_repository_storage to false the bucket is still created, it just doesn't turn up in jx-requirements.yaml.

Steps to reproduce the behavior

Create cluster with terraform configuration where a fragment looks like:

module "eks-jx" {
    source                         = "github.com/jenkins-x/terraform-aws-eks-jx?ref=v1.17.2"
    cluster_name                   = "test"
    enable_reports_storage         = false

Expected behavior

No bucket with prefix reports-test- is created.

Actual behavior

Bucket with prefix reports-test- is created.

Module version

1.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant