Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support supplying values to git-operator chart #303

Closed
msvticket opened this issue Sep 10, 2021 · 3 comments · Fixed by #306
Closed

Support supplying values to git-operator chart #303

msvticket opened this issue Sep 10, 2021 · 3 comments · Fixed by #306

Comments

@msvticket
Copy link
Member

Summary

It would be good if you could supply values to the git-operator chart.

My use case is that I need to supply the annotation eks.amazonaws.com/role-arn to sa jx-boot-job.

@ankitm123
Copy link
Member

I think the simplest solution would be to do what we do for the nginx helm chart, and provide values.yaml file. See: https://github.com/jenkins-x/terraform-aws-eks-jx/blob/master/modules/nginx/main.tf#L9

@msvticket
Copy link
Member Author

I looked at the nginx model and I don't think that is a good idea, because that means that the user needs to supply all values.

@ankitm123
Copy link
Member

ankitm123 commented Sep 10, 2021

I think that is more flexible, else we have 100 different use cases and then it becomes hard to make everyone happy 😬 . You can just give them a few values as template, and let them add more ...

user needs to supply all values.

You can also do a hybrid approach - set some common values using set and then also give users the ability to use values.yaml.
Also it's best to stick to native helm approach imo ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants