Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove hardcoded aws partition in arn #259

Merged
merged 1 commit into from
May 13, 2021
Merged

fix: remove hardcoded aws partition in arn #259

merged 1 commit into from
May 13, 2021

Conversation

ankitm123
Copy link
Member

@ankitm123 ankitm123 commented May 13, 2021

Signed-off-by: ankitm123 [email protected]

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #258

@ankitm123 ankitm123 requested a review from jstrachan May 13, 2021 03:07
@jstrachan jstrachan merged commit dc09dea into jenkins-x:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several ARN Resources are hardcoded and should use data "aws_partition" "current" {} pattern
2 participants