Skip to content

Commit ef54099

Browse files
committedJan 16, 2025
test: add case for 2 required approvals from different OWNERS
1 parent 57c16b1 commit ef54099

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed
 

‎pkg/plugins/approve/approvers/approvers_test.go

+8-3
Original file line numberDiff line numberDiff line change
@@ -400,11 +400,9 @@ func TestIsApproved(t *testing.T) {
400400
"minReviewers/2Required": minApprovers2Required,
401401
}
402402
fakeMinReviewersMap := map[string]int{
403-
"minReviewers": 1,
404-
"minReviewers/2Required": 2,
403+
"minReviewers/2RequiredNoParents": 2,
405404
}
406405
fakeNoParentsOwnersMap := map[string]bool{
407-
"minReviewers": true,
408406
"minReviewers/2Required": true,
409407
}
410408

@@ -534,6 +532,13 @@ func TestIsApproved(t *testing.T) {
534532
currentlyApproved: sets.NewString("Alice", "Derek"),
535533
isApproved: false,
536534
},
535+
{
536+
testName: "Min Reviewers/2required & other OWNERS; One from each OWNERS",
537+
filenames: []string{"a/test.go", "minReviewers/2Required/test.go"},
538+
testSeed: 0,
539+
currentlyApproved: sets.NewString("Alice", "Anne"),
540+
isApproved: true,
541+
},
537542
}
538543

539544
for _, test := range tests {

0 commit comments

Comments
 (0)