File tree 1 file changed +8
-3
lines changed
pkg/plugins/approve/approvers
1 file changed +8
-3
lines changed Original file line number Diff line number Diff line change @@ -400,11 +400,9 @@ func TestIsApproved(t *testing.T) {
400
400
"minReviewers/2Required" : minApprovers2Required ,
401
401
}
402
402
fakeMinReviewersMap := map [string ]int {
403
- "minReviewers" : 1 ,
404
- "minReviewers/2Required" : 2 ,
403
+ "minReviewers/2RequiredNoParents" : 2 ,
405
404
}
406
405
fakeNoParentsOwnersMap := map [string ]bool {
407
- "minReviewers" : true ,
408
406
"minReviewers/2Required" : true ,
409
407
}
410
408
@@ -534,6 +532,13 @@ func TestIsApproved(t *testing.T) {
534
532
currentlyApproved : sets .NewString ("Alice" , "Derek" ),
535
533
isApproved : false ,
536
534
},
535
+ {
536
+ testName : "Min Reviewers/2required & other OWNERS; One from each OWNERS" ,
537
+ filenames : []string {"a/test.go" , "minReviewers/2Required/test.go" },
538
+ testSeed : 0 ,
539
+ currentlyApproved : sets .NewString ("Alice" , "Anne" ),
540
+ isApproved : true ,
541
+ },
537
542
}
538
543
539
544
for _ , test := range tests {
You can’t perform that action at this time.
0 commit comments