fix: replace broken helm repository, upgrade bank-vault and vault

part of fix for jenkins-x/jx#8688

Author: msvticket

terraform-jx-boot/vault.tf

@@ -3,8 +3,8 @@ resource "helm_release" "vault-operator" {
   name             = "vault-operator"
   chart            = "vault-operator"
   namespace        = "jx-vault"
-  repository       = "https://kubernetes-charts.banzaicloud.com"
-  version          = "1.14.3"
+  repository       = "oci://ghcr.io/bank-vaults/helm-charts"
+  version          = "1.22.3"
   create_namespace = true
 }
 
@@ -14,6 +14,11 @@ resource "helm_release" "vault-instance" {
   chart      = "vault-instance"
   namespace  = "jx-vault"
   repository = "https://jenkins-x-charts.github.io/repo"
-  version    = "1.0.24"
+  version    = "1.0.28"
   depends_on = [helm_release.vault-operator]
-}
+
+  set {
+    name = "bankVaultsImage"
+    value = "ghcr.io/bank-vaults/bank-vaults:v1.31.2"
+  }  
+}