Skip to content

avoid deep pattern for maven-invoker-plugin generated junit files #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olamy wants to merge 2 commits into from
Closed

avoid deep pattern for maven-invoker-plugin generated junit files #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d3048
avoid deep pattern for maven-invoker-plugin generated junit files
olamy Feb 24, 2022
8eb52bb
do not need such deep scanning as surefire files are in top directory.
olamy Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vars/buildPlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def call(Map params = [:]) {
infra.runMaven(mavenOptions, jdk, null, null, addToolEnv)
} finally {
if (!skipTests) {
junit('**/target/surefire-reports/**/*.xml,**/target/failsafe-reports/**/*.xml,**/target/invoker-reports/**/*.xml')
Copy link
Contributor

@dduportal dduportal Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly this change, the junit reports that would be in nested directories (for instance target/surefire-reports/foo/test-1.xml) would not be selected anymore.

Am I correct?

Copy link
Member

@timja timja Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they are actually nested

Copy link
Author

@olamy olamy Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surefire xml files are only generated at the top level directory.

junit('**/target/surefire-reports/*.xml,**/target/failsafe-reports/*.xml,**/target/invoker-reports/TEST*.xml')
if (first) {
publishCoverage calculateDiffForChangeRequests: true, adapters: [jacocoAdapter('**/target/site/jacoco/jacoco.xml')]
}
Expand Down