Skip to content

Move babel dependencies in devDependencies #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmnsgn opened this issue Oct 8, 2021 · 1 comment
Open

Move babel dependencies in devDependencies #3

dmnsgn opened this issue Oct 8, 2021 · 1 comment

Comments

@dmnsgn
Copy link

dmnsgn commented Oct 8, 2021

express-request-queue/package.json

Lines 27 to 34 in b419eb4

"dependencies": {
"babel-cli": "^6.26.0",
"babel-plugin-transform-class-properties": "^6.24.1",
"babel-plugin-transform-object-rest-spread": "^6.26.0",
"babel-preset-env": "^1.6.1",
"body-parser": "^1.18.2",
"rimraf": "^2.6.2"
},

None of this dependencies are actually required for the module to function but including them in dependencies instead of devDependencies means they'll get installed - extraneously - alongside your module and potentially trigger security warning such as #1 .
MarkusDeutschmann added a commit to MarkusDeutschmann/express-request-queue that referenced this issue Jan 6, 2022
@MarkusDeutschmann
fixes issue jeescu#1, fixes issue jeescu#3
bf3cb40 
removed unused bode-parser dependency
moved other dependencies from dependencies to devDependencies
as they are only used for build
@MarkusDeutschmann
Copy link

Hi @jeescu,
created pull request #4 to solve it.
Could you please merge and release.

@MarkusDeutschmann MarkusDeutschmann mentioned this issue Jan 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmnsgn @MarkusDeutschmann