Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"empty" areas of some sites can't be dragged #7

Open
jedediah opened this issue Jan 7, 2010 · 5 comments
Open

"empty" areas of some sites can't be dragged #7

jedediah opened this issue Jan 7, 2010 · 5 comments

Comments

@jedediah
Copy link
Owner

jedediah commented Jan 7, 2010

This happens because the event target is the HTML element. That element needs to be made scrollable without including the scrollbar.

@arpsmack
Copy link

arpsmack commented Mar 4, 2010

There is a workaround for this that is very easy to apply. Download the source, open content.js, and locate the following function:

  // Return the first ancestor (or the element itself) that is scrollable
  function findInnermostScrollable(e) {
+    if (e == document.documentElement)
+      return document.body
+    
    if (e == null || e == document.body || isScrollable(e)) {
      return e
    } else {
      return arguments.callee(e.parentNode)
    }
  }

Adding the lines indicated by the plus signs fixed the issue in every case I could find. To install, first disable the "official" extension, and then use the developer mode tools on the extensions screen to load an unpacked extension (point it to the directory where your modified version of the extension is).

You might also want to open the manifest and bump the version number.

@arpsmack
Copy link

arpsmack commented Mar 4, 2010

Haha, I didn't even realize that you (the author) created this issue. Sorry for the explanation on how to install an unpacked extension.. :)

@jedediah
Copy link
Owner Author

jedediah commented Mar 4, 2010

Thanks for the patch. I will try and apply this tomorrow at work, assuming it doesn't bring back the broken scrollbar issue.

@jedediah
Copy link
Owner Author

jedediah commented Mar 7, 2010

It did bring back the scrollbar issue, but I found another solution to that.

@jedediah
Copy link
Owner Author

jedediah commented Apr 3, 2010

false positive scrollbar detection on this page:
http://damienkatz.net/2008/04/couchdb_language_change.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants