Can't install server on remote Windows 2019

[ShuguangSun]

I try to open remote ssh to a window 2019 box. After run connect to host command from the Remote Explorers, it estabulished the SSH connect but failed to install the server. It creates 4 folders in the Userprofile directory in the remote: $HOME, @', echo and -Force.

I have set the server type to windows inremote.SSH.remotePlatform.

By the way, I can connect to the serve in VScode.

[ShuguangSun]

The issue is still there for latest version of VScodium and open-remote-ssh.

[Hattshire]

Same issue here.
Remote is W11, locale ES-MX, default ssh shell is cmd.

I think this is the culprit:

open-remote-ssh/src/serverSetup.ts

Lines 99 to 103 in 6b30745

	if (shell === 'powershell') {
	command = `md -Force ${installDir}; echo @'\n${installServerScript}\n'@ | Set-Content ${installScript}; powershell -ExecutionPolicy ByPass -File "${installScript}"`;
	} else if (shell === 'bash') {
	command = `mkdir -p ${installDir.replace(/\\/g, '/')} && echo '\n${installServerScript.replace(/'/g, '\'"\'"\'')}\n' > ${installScript.replace(/\\/g, '/')} && powershell -ExecutionPolicy ByPass -File "${installScript}"`;
	} else if (shell === 'cmd') {

The shell is selected here:

open-remote-ssh/src/serverSetup.ts

Lines 54 to 62 in 6b30745

	} else if (result.stderr) {
	if (result.stderr.includes('FullyQualifiedErrorId : CommandNotFoundException')) {
	platform = 'windows';
	}
	if (result.stderr.includes('is not recognized as an internal or external command')) {
	platform = 'windows';
	shell = 'cmd';
	}

However, the error message is localized on my remote.

I typed md -Force $HOME\\deleteme\\install; echo @'\n-\n' after logging on ssh and it did the same (creating the -Force $HOME, echo and @' folders)
Typing the same after calling powershell it runs as intended.
So it's selecting the wrong shell in that script.

[Hattshire]

Switching to powershell on remote worked for me:
https://github.com/PowerShell/Win32-OpenSSH/wiki/DefaultShell

I think a second execution of something like echo %PATH% and checking stdout to set shell = 'cmd' (output different than %PATH% or matching \Windows\system32) should be used to maintain compatibility with localized remotes.

[GilgameshxZero]

I’m encountering the same situation as @Hattshire where my SSH is cmd but being detected as powershell.

open-remote-ssh/src/serverSetup.ts

Lines 45 to 63 in 6b30745

	const result = await conn.exec('uname -s');
	if (result.stdout) {
	if (result.stdout.includes('windows32')) {
	platform = 'windows';
	} else if (result.stdout.includes('MINGW64')) {
	platform = 'windows';
	shell = 'bash';
	}
	} else if (result.stderr) {
	if (result.stderr.includes('FullyQualifiedErrorId : CommandNotFoundException')) {
	platform = 'windows';
	}
	if (result.stderr.includes('is not recognized as an internal or external command')) {
	platform = 'windows';
	shell = 'cmd';
	}
	}

I replaced detection of the Windows shell with dir .., instead of uname -s. dir has demonstrable differences between its invocations in powershell, cmd, and (git) bash, except on an empty directory. .. is likely non-empty, except in weird permissions/home directory scenarios. I did not think about those cases very hard, so this might not work if that describes you.

https://github.com/GilgameshxZero/open-remote-ssh/blob/4b028a367afb6b698bd760884577741f9fcb1d11/src/serverSetup.ts#L45-L56

const result = await conn.exec('dir ..');

if (result.stdout) {
    platform = 'windows';
    if (result.stdout.includes('LastWriteTime')) {
        shell = 'powershell';
    } else if (result.stdout.includes('<DIR>')) {
        shell = 'cmd';
    } else {
        shell = 'bash';
    }
}

if (platform) {
    logger.trace(`Detected platform: ${platform}, ${shell}`);
}

I also tried testing locales other than en-US but could not get a non-English error message. In any case, I have a fork where I applied this fix and it works for me. You can find the release here: https://github.com/GilgameshxZero/open-remote-ssh/releases/tag/0.0.49-windows-fix.

I will open a PR shortly. Update: PR here: #240 .