Add trivial self check

Fixes cvmfs-contrib#19

Author: jcpunk

Makefile

@@ -35,6 +35,7 @@ help:
 	@echo "Available targets:"
 	@echo "  install          - Install the script to $(LIBEXECDIR), and systemd files"
 	@echo "  uninstall        - Remove installed files"
+	@echo "  check            - Check for syntax errors in $(SCRIPT_SRC)"
 	@echo "  package          - Build both RPM and DEB packages"
 	@echo "  rpm              - Build RPM package"
 	@echo "  deb              - Build DEB package"
@@ -67,6 +68,10 @@ uninstall:
 	rm -rf $(DESTDIR)$(DOCDIR)
 	@echo "Uninstall complete"
 
+check:
+	@echo "Running syntax test for $(SCRIPT_SRC)"
+	bash -n $(SCRIPT_SRC)
+
 # Package building targets
 package: rpm deb deb-source
 

cvmfs-client-prometheus.sh

@@ -40,6 +40,8 @@ declare -A CVMFS_EXTENDED_ATTRIBUTE_NAMES=(
     ['usedfd']='cvmfs_sys_usedfd'
 )
 
+'
+
 #############################################################
 usage() {
     echo "Usage: $0 [-h|--help] [--http] [--non-standard-mountpoints]" >&2

debian/rules

@@ -13,7 +13,7 @@ override_dh_auto_build:
 	# Nothing to build - this is a shell script package
 
 override_dh_auto_test:
-	# Skip tests for now
+	$(MAKE) check
 
 override_dh_install:
 	dh_install

prometheus-cvmfs-exporter.spec

@@ -51,6 +51,9 @@ make install-systemd DESTDIR=%{buildroot}
 # Remove duplicate LICENSE file from doc directory since %license handles it
 rm -f %{buildroot}%{_docdir}/%{name}/LICENSE
 
+%check
+make check
+
 %post
 %systemd_post [email protected]
 %systemd_post cvmfs-client-prometheus.socket