Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NX, XX, GT and LT to expire and pexpire #730

Open
WisdomPill opened this issue Feb 17, 2024 · 5 comments
Open

Add NX, XX, GT and LT to expire and pexpire #730

WisdomPill opened this issue Feb 17, 2024 · 5 comments

Comments

@WisdomPill
Copy link
Member

WisdomPill commented Feb 17, 2024

Problem Statement
It would be nice to fully support NX, XX, GT and LT to make it more efficient to do complex operations.
Have a look here and here

Describe the solution you'd like
Just add the flags and the tests

@sauravsharma1998
Copy link

@WisdomPill Do you want something like this?

def expire(
        self,
        key: KeyT,
        timeout: ExpiryT,
        version: Optional[int] = None,
        client: Optional[Redis] = None,
        nx: bool = False,
        xx: bool = False,
        gt: bool = False,
        lt: bool = False,
    ) -> bool:
        # Code Here

@WisdomPill
Copy link
Member Author

Hello @sauravsharma1998,

I would say yes

@ghost
Copy link

ghost commented Nov 10, 2024

Hi @WisdomPill,
I see the other PR has been inactive for a while, is this issue available?
I'm new to open-source and would love to take this up.

@WisdomPill
Copy link
Member Author

@whoiskrtk2 sure, you can follow that PR and fix the underlying issues

@ghost
Copy link

ghost commented Nov 12, 2024

Sure @WisdomPill, I'll start working on this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants