Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include tests for higher versions of Python and Django #392

Open
newearthmartin opened this issue Jul 18, 2024 · 6 comments
Open

include tests for higher versions of Python and Django #392

newearthmartin opened this issue Jul 18, 2024 · 6 comments

Comments

@newearthmartin
Copy link
Contributor

newearthmartin commented Jul 18, 2024

I just submitted a PR #391 and the tests cover python 3.7 to 3.10 and Django 2.2 to 3.2.

Can Python versions 3.11 and 3.12 and Django versions 4 and 5 be included?

@newearthmartin
Copy link
Contributor Author

Also this seems to be inaccurate in relation to the actual tests:

Screenshot 2024-07-18 at 2 11 25 PM

@sebastian-muthwill
Copy link
Member

sebastian-muthwill commented Dec 10, 2024

I just tried to get this package working since I would love to include it in one of my projects. Hence the dependencies are quite outdated.
I could try to bring together a few of the PR's to support new versions of python and django as already someone did in #389

What do you think about dropping support for Python <3.8 so #391 would not be necessary. In general also 3.8 is already EOL.

Currently I just enrolled as a member of the Jazzband and tbh I'm not really sure if I'm allowed to do any changes / merges in this repo (even if I have the rights to do so :-))

sebastian-muthwill added a commit that referenced this issue Dec 10, 2024
- dropped tests for Python <3.7
- dropped tests for Django <4.2
- added tests for Python 3.11, 3.12, 3.13
- added tests for Django >=4.2

as discussed in #392
@sebastian-muthwill
Copy link
Member

@newearthmartin I created a PR (#394) with necessary changes to make the repo up to date and could need a second pair of eyes. Need to update the documentation though.

@newearthmartin
Copy link
Contributor Author

newearthmartin commented Dec 11, 2024

@sebastian-muthwill Ok let me take a look

@newearthmartin
Copy link
Contributor Author

@sebastian-muthwill I sent you some comments as code review. Main question is: Why are we dropping so many Django versions?

@newearthmartin
Copy link
Contributor Author

Why are we dropping so many Django versions?

Expanding on this: These versions could be EOL for official Django support, but if there is no technical conflict it's not a reason for us to drop them. There may be many projects using django-newsletter with older Django versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants