Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No scheme URI should be possible #49

Open
jelko opened this issue Jan 4, 2016 · 0 comments
Open

No scheme URI should be possible #49

jelko opened this issue Jan 4, 2016 · 0 comments

Comments

@jelko
Copy link

jelko commented Jan 4, 2016

Right now it is not possible to have URIs without a scheme for relative links. Unfortunately normalize_scheme makes sure that there is always a // in place.

The documentation itself gives the example of <a href="//admin/dashboard/">Admin dashboard</a>. If admin is not a hostname/domain, this would not lead anywhere. I would suggest that admin/dashboard/ would be the better URI to build here.

I would suggest to change normalize_scheme to accept an empty string as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant