Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre_log and post_log signals not sent on m2m changes. #628

Open
gghildyal opened this issue Apr 11, 2024 · 3 comments
Open

pre_log and post_log signals not sent on m2m changes. #628

gghildyal opened this issue Apr 11, 2024 · 3 comments

Comments

@gghildyal
Copy link

Usually when creating a model object, first the model is created with non-m2m fields and then m2m fields are set on the model to save it. The first operator creates a LogEntry object and sends a pre_log and post_log signals as expected. On receiving m2m_changed signal, a LogEntry is created for the change but a pre_log or post_log signal isn't sent.

@gghildyal
Copy link
Author

This was found in 3.0.b4.

@hramezani
Copy link
Member

Thanks @gghildyal for reporting this.

Yeah, django-auditlog has pre_log and post_log signals but it doesn't send them in m2m_changed.

It would be good to send these signals there.

@hoangquochung1110
Copy link
Contributor

Hi @hramezani @gghildyal

I'd like to work on this but not quite sure how to reproduce it. Could you guys help shed some light on it ? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants