Open
Description
Follow-up to #438
How should we deal with Pump
s? Currently, they are separate from the Channel
. We could also merge them and have something like self.ion_name=None
(or self.ion_name = "v") for
Channel`s.
Currently, we define self.pumps
and self.pumped_ions
. As @jnsbck suggested, we could also define self.pumps = {"ion_name": [pump1, pump2]}
. If we merge Pump
s and Channel
s, we could even have:
self.mechanisms = {"v": [channel1, channel2], "ca": [pump1], "na": [pump2]}
A downside of this is that
- by removing the
Pump
, we lose the opportunity to write explicit docstrings that explain what aPump
is - we hide that a
Pump
and aChannel
differ in their units and in the fact thatchannel
s get the current divided by the capacitance.
A final option would be to only go for the dict
representation for Pump
s. This has the downside that:
- we now handle pumps and channels differently
- we can no longer do
self.channels + self.pumps
But it has the big advantage of having only one attribute (get rid of self.pumped_ions
)
Metadata
Metadata
Assignees
Labels
No labels