From fd9e8271bdfd848d5e9faf8a7cb7dcbcc43f7a16 Mon Sep 17 00:00:00 2001 From: Sebastiano Degan Date: Wed, 24 Feb 2021 21:21:20 +0100 Subject: [PATCH 1/2] removed useless regex characters escape --- src/search.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/search.js b/src/search.js index 06c2d4b1..b2577dbe 100755 --- a/src/search.js +++ b/src/search.js @@ -28,7 +28,6 @@ module.exports = function (list) { }, setSearchString: function (s) { s = list.utils.toString(s).toLowerCase() - s = s.replace(/[-[\]{}()*+?.,\\^$|#]/g, '\\$&') // Escape regular expression characters searchString = s }, toArray: function (values) { From 999ef601d59b7416a850682fc1b168e86c9d8f1e Mon Sep 17 00:00:00 2001 From: Sebastiano Degan Date: Wed, 24 Feb 2021 21:33:42 +0100 Subject: [PATCH 2/2] re-enabled tests on special chars --- __test__/search.test.js | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/__test__/search.test.js b/__test__/search.test.js index ec2abc7e..863881f0 100755 --- a/__test__/search.test.js +++ b/__test__/search.test.js @@ -196,22 +196,24 @@ describe('Search', function () { }) }) - // - // describe('Special characters', function() { - // it('should escape and handle special characters', function() { - // list.add([ - // { name: 'Jonny&Jabba' }, - // { name: 'Luke' }, - // { name: '"Chewie"' }, - // { name: "'Ewok'" } - // ]); - // var result = list.search('Leia'); - // console.log(result); - // expect(result.length).toEqual(1); - // var result = list.search('<'); - // console.log(result); - // expect(result.length).toEqual(1); - // }); - // }); + describe('Special characters', function() { + it('should escape and handle special characters', function() { + list.add([ + { name: 'Jonny Jr.' }, + { name: 'Jonny&Jabba' }, + { name: 'Luke' }, + { name: '"Chewie"' }, + { name: "'Ewok'" } + ]); + var result = list.search('Leia'); + expect(result.length).toEqual(1); + + var result = list.search('<'); + expect(result.length).toEqual(1); + + var result = list.search('Jr.'); + expect(result.length).toEqual(1); + }); + }); })