Skip to content

Commit 6644e68

Browse files
committed
registry entry valuedata and valuename no mandatory in msi generation (fixed)
1 parent e5e22e2 commit 6644e68

File tree

1 file changed

+16
-4
lines changed

1 file changed

+16
-4
lines changed

src/main/resources/windows/msm.wxs.vtl

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,25 @@
44
#set($guid = $GUID.randomUUID())
55
#set($id = $id + 1)
66
#if($file.isDirectory())
7+
#if($file.equals(${info.appFolder}))
8+
<Directory Id="INSTALLFOLDER" Name="${file.name}">
9+
#else
710
<Directory Id="_${id}" Name="${file.name}">
11+
#end
812
#foreach($child in $file.listFiles())
913
#list($child)
1014
#end
1115
</Directory>
1216
#else
1317
<Component Id="_${id}" Guid="${guid}" Win64="yes">
1418
#if($file.equals(${info.executable}))
15-
<File Id="exeFile" Name="${file.name}" KeyPath="yes" Source="${file}">
19+
<File Id="EXEFILE" Name="${file.name}" KeyPath="yes" Source="${file}">
1620
<Shortcut Id="ApplicationStartMenuShortcut" Name="${info.winConfig.shortcutName}" Description="${info.description}" Directory="ProgramMenuFolder" />
1721
</File>
1822
<RemoveFolder Id="ApplicationProgramsFolder" On="uninstall" />
1923
<RegistryValue Root="HKLM" Key="Software\\${info.organizationName}\\${info.name}" Name="installed" Type="integer" Value="1" />
2024
#else
21-
<File Id="_${id}f" Name="${file.name}" KeyPath="yes" Source="${file}"/>
25+
<File Name="${file.name}" KeyPath="yes" Source="${file}"/>
2226
#end
2327
</Component>
2428
#end
@@ -33,8 +37,16 @@
3337
#if ($info.winConfig.registry)
3438
<Component Id="RegistryEntries" Guid="${GUID.randomUUID()}">
3539
#foreach ($entry in $info.winConfig.registry.entries)
36-
<RegistryKey Root="${entry.root}" Key="${entry.subkey}" Action="createAndRemoveOnUninstall">
37-
<RegistryValue Type="${entry.valueTypeAsWIXToolsetString}" Name="$!{entry.valueName}" Value="$!{entry.valueData}"/>
40+
<RegistryKey Root="${entry.root}" Key="${entry.subkey}" ForceDeleteOnUninstall="yes">
41+
<RegistryValue
42+
Type="${entry.valueTypeAsWIXToolsetString}"
43+
#if ($entry.valueName)
44+
Name="$!{entry.valueName}"
45+
#end
46+
#if ($entry.valueData)
47+
Value="$!{entry.valueData}"
48+
#end
49+
/>
3850
</RegistryKey>
3951
#end
4052
</Component>

0 commit comments

Comments
 (0)