Skip to content

Commit 4c12b0f

Browse files
committed
Linting/tidy
1 parent 0d2a9cb commit 4c12b0f

File tree

7 files changed

+167
-138
lines changed

7 files changed

+167
-138
lines changed

src/main/kotlin/no/java/conf/model/search/TextSearchRequest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package no.java.conf.model.search
22

33
import kotlinx.serialization.Serializable
4-
import no.java.conf.model.sessions.Format
54

65
@Serializable
76
data class TextSearchRequest(
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,18 @@
11
package no.java.conf.plugins
22

3-
import io.ktor.client.HttpClient
43
import io.ktor.server.application.Application
5-
import no.java.conf.model.EndpointConfig
64
import no.java.conf.service.LocalFileConfig
75
import no.java.conf.service.LocalFileService
8-
import no.java.conf.service.SleepingPillService
96

7+
fun localFileService(config: List<LocalFileConfig>) =
8+
LocalFileService(
9+
filenames = config,
10+
)
1011

11-
fun localFileService(
12-
config: List<LocalFileConfig>
13-
) = LocalFileService(
14-
filenames = config,
15-
)
16-
17-
18-
fun Application.localFileService() = localFileService(
19-
config = environment.config.configList("javazone.localfile").map {
20-
LocalFileConfig(it.property("year").getString().toInt(), it.property("filename").getString())
21-
},
22-
)
12+
fun Application.localFileService() =
13+
localFileService(
14+
config =
15+
environment.config.configList("javazone.localfile").map {
16+
LocalFileConfig(it.property("year").getString().toInt(), it.property("filename").getString())
17+
},
18+
)

src/main/kotlin/no/java/conf/plugins/Search.kt

+32-22
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,12 @@ import io.ktor.server.routing.routing
1414
import no.java.conf.model.search.TextSearchRequest
1515
import no.java.conf.service.SearchService
1616

17-
fun searchClient(host: String, port: Int, username: String, password: String) = SearchClient(
17+
fun searchClient(
18+
host: String,
19+
port: Int,
20+
username: String,
21+
password: String
22+
) = SearchClient(
1823
KtorRestClient(
1924
host = host,
2025
port = port,
@@ -23,31 +28,36 @@ fun searchClient(host: String, port: Int, username: String, password: String) =
2328
),
2429
)
2530

26-
fun Application.searchClient() = searchClient(
27-
host = environment.config.property("elastic.host").getString(),
28-
port = environment.config
29-
.property("elastic.port")
30-
.getString()
31-
.toInt(),
32-
username = environment.config.property("elastic.username").getString(),
33-
password = environment.config.property("elastic.password").getString(),
34-
)
35-
36-
fun searchService(searchClient: SearchClient, skipIndex: Boolean) =
37-
SearchService(
38-
client = searchClient,
39-
skipIndex = skipIndex,
31+
fun Application.searchClient() =
32+
searchClient(
33+
host = environment.config.property("elastic.host").getString(),
34+
port =
35+
environment.config
36+
.property("elastic.port")
37+
.getString()
38+
.toInt(),
39+
username = environment.config.property("elastic.username").getString(),
40+
password = environment.config.property("elastic.password").getString(),
4041
)
4142

42-
43-
fun Application.searchService() = searchService(
44-
searchClient = searchClient(),
45-
skipIndex = environment.config
46-
.property("elastic.skipindex")
47-
.getString()
48-
.toBoolean()
43+
fun searchService(
44+
searchClient: SearchClient,
45+
skipIndex: Boolean
46+
) = SearchService(
47+
client = searchClient,
48+
skipIndex = skipIndex,
4949
)
5050

51+
fun Application.searchService() =
52+
searchService(
53+
searchClient = searchClient(),
54+
skipIndex =
55+
environment.config
56+
.property("elastic.skipindex")
57+
.getString()
58+
.toBoolean()
59+
)
60+
5161
fun Application.configureSearchRouting(service: SearchService) {
5262
routing {
5363
route("/api/search") {

src/main/kotlin/no/java/conf/plugins/SleepingPill.kt

+8-10
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import io.ktor.server.application.Application
55
import no.java.conf.model.EndpointConfig
66
import no.java.conf.service.SleepingPillService
77

8-
98
fun sleepingPillService(
109
httpClient: HttpClient,
1110
endpoints: List<EndpointConfig>
@@ -14,12 +13,11 @@ fun sleepingPillService(
1413
endpoints = endpoints,
1514
)
1615

17-
18-
fun Application.sleepingPillService(
19-
httpClient: HttpClient,
20-
) = sleepingPillService(
21-
httpClient = httpClient,
22-
endpoints = environment.config.configList("javazone.sleepingpill").map {
23-
EndpointConfig(it.property("year").getString().toInt(), it.property("endpoint").getString())
24-
},
25-
)
16+
fun Application.sleepingPillService(httpClient: HttpClient) =
17+
sleepingPillService(
18+
httpClient = httpClient,
19+
endpoints =
20+
environment.config.configList("javazone.sleepingpill").map {
21+
EndpointConfig(it.property("year").getString().toInt(), it.property("endpoint").getString())
22+
},
23+
)

src/main/kotlin/no/java/conf/service/LocalFileService.kt

+23-27
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
11
package no.java.conf.service
22

33
import io.github.oshai.kotlinlogging.KotlinLogging
4-
import io.ktor.client.HttpClient
5-
import io.ktor.client.call.body
64
import io.ktor.client.request.get
7-
import kotlinx.coroutines.async
8-
import kotlinx.coroutines.awaitAll
9-
import kotlinx.coroutines.coroutineScope
105
import kotlinx.serialization.json.Json
11-
import no.java.conf.model.EndpointConfig
126
import no.java.conf.model.sessions.Session
13-
import no.java.conf.model.sleepingpill.SPSession
147
import no.java.conf.model.sleepingpill.SPSessions
158
import no.java.conf.model.sleepingpill.toSession
169

@@ -26,28 +19,31 @@ class LocalFileService(
2619
) {
2720
private lateinit var sessions: List<Session>
2821

29-
private val json = Json {
30-
prettyPrint = true
31-
ignoreUnknownKeys = true
32-
isLenient = true
33-
explicitNulls = false
34-
}
22+
private val json =
23+
Json {
24+
prettyPrint = true
25+
ignoreUnknownKeys = true
26+
isLenient = true
27+
explicitNulls = false
28+
}
3529

3630
fun read(): List<Session> {
37-
sessions = filenames.map {
38-
val fileContent = javaClass.getResource(it.filename).readText()
39-
40-
val decodedSessions = json.decodeFromString<SPSessions>(fileContent)
41-
42-
decodedSessions.sessions.map { session ->
43-
session.toSession(it.year).copy(
44-
id = "Local-${it.year}-${session.id}",
45-
sessionId = "Local-${it.year}-${session.id}",
46-
conferenceId = "Local-${it.year}",
47-
)
48-
}
49-
50-
}.flatten().also { logger.debug { "Local File - sessions: ${it.count()}" } }
31+
sessions =
32+
filenames
33+
.map {
34+
val fileContent = javaClass.getResource(it.filename).readText()
35+
36+
val decodedSessions = json.decodeFromString<SPSessions>(fileContent)
37+
38+
decodedSessions.sessions.map { session ->
39+
session.toSession(it.year).copy(
40+
id = "Local-${it.year}-${session.id}",
41+
sessionId = "Local-${it.year}-${session.id}",
42+
conferenceId = "Local-${it.year}",
43+
)
44+
}
45+
}.flatten()
46+
.also { logger.debug { "Local File - sessions: ${it.count()}" } }
5147

5248
return sessions
5349
}

0 commit comments

Comments
 (0)