Skip to content

Commit e443ada

Browse files
authored
Use ngrok rather than localtunnel when running browser tests (#668)
These changes makes zuul use ngrok for exposing itself to the outside world, rather than the default localtunnel implementation. That's because we've had quite a lot of issues with flakyness which seems to be related to localtunnel, e.g.: ``` - starting: <internet explorer 9 on Windows 2008> events.js:160 throw er; // Unhandled 'error' event ^ Error: connection refused: localtunnel.me:44896 (check your firewall settings) at Socket.<anonymous> (/home/travis/build/janl/mustache.js/node_modules/localtunnel/client.js:84:32) at emitOne (events.js:96:13) at Socket.emit (events.js:188:7) at emitErrorNT (net.js:1290:8) at _combinedTickCallback (internal/process/next_tick.js:80:11) at process._tickCallback (internal/process/next_tick.js:104:9) ``` I thought this was fixed by [using Node.js 6 instead of Node.js 4](#667), but sadly that was not the case as it re-appeared with Node.js 6 as well. Had to use a [custom version of zuul-ngrok](https://github.com/rase-/zuul-ngrok/pull/12) which contains a newer version of ngrok. The dependency used by the upstream module threw an error when running on my computer, the updated version worked as a charm though. We should change to using the upstream module as soon as the PR with that ngrok version bump lands. Set `concurrency: 1` otherwise ngrok would fail and make IE11 tests stall forever because of too many connections being made within a short time period. I've notice it can take quite some time (20+ minutes) to get all the tests through as it seems ngrok still seems to throttle the connections somehow, but the important thing is getting these tests to work.
1 parent 5bbe25e commit e443ada

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.zuul.yml

+5-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,8 @@ browsers:
55
- name: firefox
66
version: latest
77
- name: ie
8-
version: 9..latest
8+
version: 9..latest
9+
concurrency: 1
10+
tunnel:
11+
type: ngrok
12+
bind_tls: false

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
"jshint": "^2.9.5",
4646
"mocha": "^3.0.2",
4747
"uglify-js": "^3.4.6",
48-
"zuul": "^3.11.0"
48+
"zuul": "^3.11.0",
49+
"zuul-ngrok": "nolanlawson/zuul-ngrok#patch-1"
4950
},
5051
"spm": {
5152
"main": "mustache.js",

0 commit comments

Comments
 (0)