fix(aot): make loaded-modules-in-order thread safe

Author: Samy-33

compiler+runtime/include/cpp/jank/runtime/context.hpp

@@ -140,7 +140,7 @@ namespace jank::runtime
     /* TODO: This needs to be a dynamic var. */
     native_unordered_map<jtl::immutable_string, native_vector<jtl::immutable_string>>
       module_dependencies;
-    native_deque<jtl::immutable_string> loaded_modules_in_order;
+    folly::Synchronized<native_deque<jtl::immutable_string>> loaded_modules_in_order;
     jtl::immutable_string binary_cache_dir;
     module::loader module_loader;
 

compiler+runtime/src/cpp/jank/aot/processor.cpp

@@ -76,7 +76,9 @@ extern "C" jank_object_ref jank_call2(jank_object_ref, jank_object_ref, jank_obj
 extern "C" jank_object_ref jank_parse_command_line_args(int, char const **);
 )");
 
-    for(auto const &m : __rt_ctx->loaded_modules_in_order)
+    /* TODO: Is there a better way to do this then copying? */
+    auto const ordered_modules{ __rt_ctx->loaded_modules_in_order.copy() };
+    for(auto const &m : ordered_modules)
     {
       util::format_to(sb,
                       R"(extern "C" jank_object_ref {}();)",
@@ -95,7 +97,7 @@ int main(int argc, const char** argv)
 
     )");
 
-    for(auto const &m : __rt_ctx->loaded_modules_in_order)
+    for(auto const &m : ordered_modules)
     {
       util::format_to(sb, "{}();\n", module::module_to_load_function(m));
     }
@@ -167,7 +169,8 @@ int main(int argc, const char** argv)
 
     std::vector<char const *> Args = { strdup(clang_inferred_path.get().c_str()) };
 
-    for(auto const &module : __rt_ctx->loaded_modules_in_order)
+    /* TODO: Can we avoid copying? */
+    for(auto const &module : __rt_ctx->loaded_modules_in_order.copy())
     {
       auto const &module_path{
         util::format("{}.o", relative_to_cache_dir(module::module_to_path(module)))

compiler+runtime/src/cpp/jank/runtime/module/loader.cpp

@@ -654,7 +654,10 @@ namespace jank::runtime::module
     }
 
     loader::set_is_loaded(module);
-    __rt_ctx->loaded_modules_in_order.push_back(module);
+    {
+      auto const locked_ordered_modules{ __rt_ctx->loaded_modules_in_order.wlock() };
+      locked_ordered_modules->push_back(module);
+    }
     return ok();
   }