refactor: string trim set true for whole schema#47
Closed
prashantk01 wants to merge 2 commits intoafteracademy:masterfrom
Closed
refactor: string trim set true for whole schema#47prashantk01 wants to merge 2 commits intoafteracademy:masterfrom
prashantk01 wants to merge 2 commits intoafteracademy:masterfrom
Conversation
prashantk01
commented
Sep 12, 2022
prashantk01
commented
- mongoose is upgraded
- timestamps set to true ( no need to create schema fields for createdAt and updatedAt)
…ted to support String.set, set timestamps to true
janishar
reviewed
Dec 12, 2023
Collaborator
janishar
left a comment
janishar
left a comment
There was a problem hiding this comment.
Implementation will be better if we have schema.set('timestamps', true); with select:false for createdAt and updatedAt in find based queries. These fields should not be returned in query by default. If you can provide this solution then it can be considered for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.