docs: align local API port examples with current dev flow#250
docs: align local API port examples with current dev flow#250pandego wants to merge 1 commit intojamiepine:mainfrom
Conversation
📝 WalkthroughWalkthroughThe pull request updates API endpoint references from port 8000 to port 17493 across documentation files and a shell script, reflecting the new default backend port for local development workflows. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
scripts/generate-api.sh (2)
34-34: Static analysis: Unused loop variablei.The loop variable
iis unused (SC2034). This is a pre-existing issue unrelated to this PR's changes, but you could suppress the warning or use_as the variable name.♻️ Optional fix to suppress warning
- for i in {1..30}; do + for _ in {1..30}; do🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/generate-api.sh` at line 34, The for-loop in generate-api.sh uses an unused loop variable `i` ("for i in {1..30}; do"), triggering SC2034; either replace `i` with `_` (e.g., "for _ in {1..30}; do") to indicate intentional unused variable or add a ShellCheck suppression comment above the loop (e.g., "# shellcheck disable=SC2034") to silence the warning; update the loop header surrounding "for i in {1..30}; do" accordingly.
29-29: Port configurations serve different contexts and are intentional.The script uses port 17493 via explicit
--port 17493argument, whilebackend/server.pydefaults to port 8000 when no port is specified. This design is reasonable: the script specifies its automation-specific port, while the backend remains flexible via the--portargument. Developers running the backend directly (python -m backend.main) will naturally use the default 8000, which is appropriate for local development.If clarity is desired, consider adding an inline comment in the script noting why 17493 is used.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/generate-api.sh` at line 29, Add an inline comment next to the uvicorn invocation in generate-api.sh explaining why the specific port 17493 is used (automation/CI-specific port) to avoid confusion with backend/server.py's default 8000; update the line containing the uvicorn command (uvicorn main:app --port 17493 &) to include that brief explanatory comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/generate-api.sh`:
- Line 34: The for-loop in generate-api.sh uses an unused loop variable `i`
("for i in {1..30}; do"), triggering SC2034; either replace `i` with `_` (e.g.,
"for _ in {1..30}; do") to indicate intentional unused variable or add a
ShellCheck suppression comment above the loop (e.g., "# shellcheck
disable=SC2034") to silence the warning; update the loop header surrounding "for
i in {1..30}; do" accordingly.
- Line 29: Add an inline comment next to the uvicorn invocation in
generate-api.sh explaining why the specific port 17493 is used
(automation/CI-specific port) to avoid confusion with backend/server.py's
default 8000; update the line containing the uvicorn command (uvicorn main:app
--port 17493 &) to include that brief explanatory comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f63f0c53-c438-4d98-801c-3b72f4f23aa9
📒 Files selected for processing (5)
CONTRIBUTING.mdREADME.mdbackend/README.mddocs/TROUBLESHOOTING.mdscripts/generate-api.sh
Summary
What changed
README.mdAPI examples to usehttp://localhost:17493backend/README.mdusage examples and note that manual launches can use a different host or portdocs/TROUBLESHOOTING.mdhealth and OpenAPI checks to use17493CONTRIBUTING.mdtroubleshooting guidance for OpenAPI client generationscripts/generate-api.shto matchbun run dev:serverWhy
The repo currently has mixed references to
8000and17493. The current local app, web client, and development workflow use17493, while some older docs and helper tooling still point at8000. This patch aligns the user-facing docs and the OpenAPI generation helper with the modern local/dev flow without changing backend runtime defaults.Validation
17493scripts/generate-api.shpreviously disagreed withbun run dev:serverSummary by CodeRabbit
Release Notes
Documentation
Chores