Skip to content

Current "get around" require statement breaks #9

Open
@dapplion

Description

@dapplion

Running Lodestar on this branch ChainSafe/lodestar#2328 breaks with

TypeError: Class extends value undefined is not a constructor or null
    at Object.<anonymous> (/usr/app/node_modules/timeout-abort-controller/index.js:12:33)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/usr/app/node_modules/libp2p/src/dialer/index.js:9:27)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
/usr/app/node_modules/timeout-abort-controller/index.js:12
class TimeoutController extends AbortController {
                                ^

Seems that this detection does not cover some corner case

const { AbortController } =
typeof self !== 'undefined' ? self
: typeof window !== 'undefined' ? window
/* otherwise */ : require('abort-controller')

CC @wemeetagain

Example of error https://github.com/ChainSafe/lodestar/runs/2272944508?check_suite_focus=true#step:7:7

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions