Skip to content

Commit 12190a2

Browse files
authored
Merge pull request google#2476 from iwankgb/using_value_before_checking_for_error
Returning error before using value
2 parents 7f840ac + 3342050 commit 12190a2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

machine/machine.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ func GetMachineMemoryByType(edacPath string) (map[string]*info.MemoryInfo, error
168168
continue
169169
}
170170
memType, err := ioutil.ReadFile(path.Join(edacPath, controller, dimm, memTypeFileName))
171-
readableMemType := strings.TrimSpace(string(memType))
172171
if err != nil {
173172
return map[string]*info.MemoryInfo{}, err
174173
}
174+
readableMemType := strings.TrimSpace(string(memType))
175175
if _, exists := memory[readableMemType]; !exists {
176176
memory[readableMemType] = &info.MemoryInfo{}
177177
}

0 commit comments

Comments
 (0)