Updates some methods and code optimizations.

Author: izniburak

src/Router.php

@@ -11,6 +11,7 @@
 */
 namespace Buki;
 
+use Closure;
 use ReflectionMethod;
 use Buki\Router\RouterRequest;
 use Buki\Router\RouterCommand;
@@ -19,22 +20,22 @@
 class Router
 {
     /**
-     * @var $baseFolder Pattern definations for parameters of Route
+     * @var string $baseFolder Pattern definations for parameters of Route
      */
     protected $baseFolder;
 
     /**
-     * @var $routes Routes list
+     * @var array $routes Routes list
      */
     protected $routes = [];
 
     /**
-     * @var $groups List of group routes
+     * @var array $groups List of group routes
      */
     protected $groups = [];
 
     /**
-     * @var $patterns Pattern definations for parameters of Route
+     * @var array $patterns Pattern definations for parameters of Route
      */
     protected $patterns = [
         '{a}' => '([^/]+)',
@@ -47,33 +48,33 @@ class Router
     ];
 
     /**
-     * @var $namespaces Namespaces of Controllers and Middlewares files
+     * @var array $namespaces Namespaces of Controllers and Middlewares files
      */
     protected $namespaces = [
         'middlewares' => '',
         'controllers' => ''
     ];
 
     /**
-     * @var $path Paths of Controllers and Middlewares files
+     * @var array $path Paths of Controllers and Middlewares files
      */
     protected $paths = [
         'controllers' => 'Controllers',
         'middlewares' => 'Middlewares'
     ];
 
     /**
-     * @var $mainMethod Main method for controller
+     * @var string $mainMethod Main method for controller
      */
     protected $mainMethod = 'main';
 
     /**
-     * @var $errorCallback Route error callback function
+     * @var Closure $errorCallback Route error callback function
      */
     protected $errorCallback;
 
     /**
-     * Router constructer method.
+     * Router constructor method.
      * 
      * @param array $params
      *
@@ -97,6 +98,8 @@ function __construct(array $params = [])
     /**
      * Set paths and namespaces for Controllers and Middlewares.
      *
+     * @param array $params
+     *
      * @return void
      */
     protected function setPaths($params)
@@ -138,7 +141,11 @@ protected function setPaths($params)
      * Add route method;
      * Get, Post, Put, Delete, Patch, Any, Ajax...
      *
+     * @param $method
+     * @param $params
+     *
      * @return void
+     * @throws
      */
     public function __call($method, $params)
     {
@@ -223,6 +230,7 @@ public function add($methods, $route, $settings, $callback = null)
      * @param null|string $attr
      * 
      * @return void
+     * @throws
      */
     public function pattern($pattern, $attr = null)
     {
@@ -249,7 +257,7 @@ public function pattern($pattern, $attr = null)
      * Run Routes
      *
      * @return void
-     * @throw Exception
+     * @throws
      */
     public function run()
     {
@@ -408,6 +416,7 @@ public function group($name, $settings = null, $callback = null)
      * @param null|string $controller
      * 
      * @return void
+     * @throws
      */
     public function controller($route, $settings, $controller = null)
     {
@@ -457,6 +466,8 @@ public function controller($route, $settings, $controller = null)
             }
             unset($r);
         }
+
+        return;
     }
 
     /**
@@ -528,6 +539,8 @@ private function addRoute($uri, $method, $callback, $settings)
     /**
      * Run Route Command; Controller or Closure
      *
+     * @param $command
+     * @param $params
      * @return null
      */
     private function runRouteCommand($command, $params = null)
@@ -612,6 +625,7 @@ public function getRoutes()
      * @param $message
      *
      * @return RouterException
+     * @throws
      */
     public function exception($message = '')
     {

src/Router/RouterCommand.php

@@ -10,19 +10,17 @@
 
 namespace Buki\Router;
 
-use Buki\Router\RouterException;
-
 class RouterCommand
 {
     /**
-     * @var Class instance variable
+     * @var RouterCommand|null Class instance variable
      */
     protected static $instance = null;
 
     /**
      * Get class instance
      *
-     * @return PdoxObject
+     * @return RouterCommand
      */
     public static function getInstance()
     {
@@ -36,7 +34,9 @@ public static function getInstance()
      * Throw new Exception for Router Error
      *
      * @param $message
+     *
      * @return RouterException
+     * @throws
      */
     public function exception($message = '')
     {
@@ -50,7 +50,8 @@ public function exception($message = '')
      * @param $path 
      * @param $namespace
      * 
-     * @return void
+     * @return mixed|void
+     * @throws
      */
     public function beforeAfter($command, $path = '', $namespace = '')
     {
@@ -81,6 +82,7 @@ public function beforeAfter($command, $path = '', $namespace = '')
      * @param $namespace 
      * 
      * @return void
+     * @throws
      */
     public function runRoute($command, $params = null, $path = '', $namespace = '')
     {
@@ -117,6 +119,7 @@ public function runRoute($command, $params = null, $path = '', $namespace = '')
      * @param $namespace  
      * 
      * @return object
+     * @throws
      */
     protected function resolveClass($class, $path, $namespace)
     {

src/Router/RouterException.php

@@ -15,15 +15,17 @@
 class RouterException
 {
     /**
-     * @var $debug Debug mode
+     * @var bool $debug Debug mode
      */
     public static $debug = false;
 
     /**
      * Create Exception Class.
      *
+     * @param $message
+     *
      * @return string
-     * @throw Exception
+     * @throws Exception
      */
     public function __construct($message)
     {

src/Router/RouterRequest.php

@@ -13,13 +13,16 @@
 class RouterRequest
 {
     /**
-     * @var $validMethods Valid methods for Requests
+     * @var string $validMethods Valid methods for Requests
      */
     public static $validMethods = 'GET|POST|PUT|DELETE|HEAD|OPTIONS|PATCH|ANY|AJAX|AJAXP';
 
     /**
      * Request method validation
      *
+     * @param string $data
+     * @param string $method
+     *
      * @return bool
      */
     public static function validMethod($data, $method)
@@ -42,7 +45,10 @@ public static function validMethod($data, $method)
     /**
      * check method valid
      *
-     * @return true|false
+     * @param string $value
+     * @param string $method
+     *
+     * @return bool
      */
     protected static function checkMethods($value, $method)
     {
@@ -83,7 +89,7 @@ protected static function getRequestHeaders()
         // Method getallheaders() not available: manually extract 'm
         $headers = [];
         foreach ($_SERVER as $name => $value) {
-            if ((substr($name, 0, 5) == 'HTTP_') || ($name === 'CONTENT_TYPE') || ($name === 'CONTENT_LENGTH')) {
+            if (substr($name, 0, 5) == 'HTTP_' || $name === 'CONTENT_TYPE' || $name === 'CONTENT_LENGTH') {
                 $headers[str_replace([' ', 'Http'], ['-', 'HTTP'], ucwords(strtolower(str_replace('_', ' ', substr($name, 5)))))] = $value;
             }
         }
@@ -102,10 +108,10 @@ public static function getRequestMethod()
         $method = $_SERVER['REQUEST_METHOD'];
         // If it's a HEAD request override it to being GET and prevent any output, as per HTTP Specification
         // @url http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.4
-        if ($method == 'HEAD') {
+        if ($method === 'HEAD') {
             ob_start();
             $method = 'GET';
-        } elseif ($method == 'POST') {
+        } elseif ($method === 'POST') {
             $headers = self::getRequestHeaders();
             if (isset($headers['X-HTTP-Method-Override']) && in_array($headers['X-HTTP-Method-Override'], ['PUT', 'DELETE', 'PATCH', 'OPTIONS'])) {
                 $method = $headers['X-HTTP-Method-Override'];