[Suggestion] mögliche Verbesserung der Implementation von UrnOR::next()

[arrrrrrrrrrrrrr]

What could be improved?

Die Implementation von UrnOR::next() kommt mir ein bisschen umständlich/ineffizient vor. Im worst case läuft sie in O(n^2), während ich denke, dass O(n) möglich ist (siehe Vorschlag).
LG!

Do you have a suggestion on how to improve it?

bool UrnOR::next() 
{
	uint down { m_k };
	
	while (down > 1 && m_balls[down-1] == m_n-1) 
	{
		m_balls[down-1] = 0;
		down--;
	}
	if (down > 0 && m_balls[down-1] < m_n-1) 
	{
		m_balls[down-1]++;
		return true;
	}
	return false;
}

[programming-book-bot]

Hi,

thanks for your suggested improvement. I just checked whether the code is correct - it is! I also checked whether it is an improvement - it is!

The question is: How to proceed? If you agree, please send my your real name and I will include it it an corresponding comment in the next code revision of urn.hpp, e.g. "Improved implementation suggested by xxx." Would that be ok for you?

[arrrrrrrrrrrrrr]

Yes, that's fine, thank you. My name is Agathe Freywald.