Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VOUnit reference #5

Open
gmantele opened this issue Jan 18, 2024 · 1 comment
Open

Add VOUnit reference #5

gmantele opened this issue Jan 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@gmantele
Copy link

A user noticed that the column TAP_SCHEMA.columns.unit as described in Sec. 4.3 of TAP-1.1 does not require or even does not mention the standard VOUnit. Should values of this column follows VOUnit or is it completely free?

@gmantele gmantele added the bug Something isn't working label Jan 18, 2024
@mbtaylor
Copy link
Member

Since the units metadata is likely to make its way into output VOTables, it would make sense for both the TAP_SCHEMA.columns.unit column and the corresponding unit element defined in VODataService to follow the same rules as VOTable. The relevant text in VOTable has been in some flux, but following recent discussion (ivoa-std/VOTable#28), the current WD-VOTable-1.5 sec 4.4 says:

The syntax of the unit string SHOULD conform to the VOUnits specification

so I would say an addition of similar text in TAP (and VODataService) would be a good idea.

It's probably not fair to call the omission of such text in TAP-1.1 a bug, since REC-TAP-1.1 was published a little before REC-VOTable-1.4, which was the first VOTable version to mention VOUnits (VOTable 1.3 and earlier recommended use of the CDS catstd unit syntax).

@gmantele gmantele added enhancement New feature or request and removed bug Something isn't working labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants