-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EpochPosition position/pm errors #73
Comments
The flatter it is, the more constrained it gets. I actually think that might be a good thing... a GaiaPosition would be very clear about what context it should be used and help with another concern I noted, about using mango:EpochPosition when meas:Position is all that is needed/wanted. |
In my understanding the correlation matrix relates to the parameters themselves, not the errors.
Let's take an example:
I propose:
|
OK, I see that there needs to be some way in general to model symmetric and asymmetric 1-d errors. The problem here is with 2-d errors. I don't understand this comment:
The correlation is the scaled off-diagonal elements of the covariance matrix, and the errors are the square root of diagonal elements of the covariance matrix. So e.g. if a client is looking for the correlation between lat and lon using the current draft, it could look in either
or
This redundancy is not helpful when trying to make sense of the annotation. Although I understand conceptually that sky position and proper motion both seem like 2-d quantities that should have a 2-d covariance/correlation matrix, this is not how the Gaia observational data appears. Because of the way that the Gaia processing is done, the Gaia observations relevant for epoch propagation are:
(errors and correlations could alternatively be represented using a 5*5 symmetric covariance matrix, though that's not how they appear in the gaia_source catalogue). Trying to represent this data using 2-d correlation/covariance matrices won't work well (redundancy, missing data or confusing representations will result), which is why I asked for the correlations in the earlier draft to be flattened. A partial flattening doesn't help much. As per @mcdittmar's remark above, I understand that this is highly specific to Gaia data, but if you want to represent all the statistical information from gaia_source in a straightforward way, it's hard to avoid doing something like this. If you're more concerned with generality than with representation of Gaia data, then you might want to do something else, but I'd still advise to try to avoid redundancy (which is also potential for contradiction). |
To me, the right path is to stay close to the GAIA data (vector + correlations + errors) without closing the door to some flexibility (e.g. error polymorphism)
Handled by the
Handled by the
Handled by the very flat Remark: using matrices in the annotations is very painful for all stack holders since the role of a given element is given by its rank in a matrix row. (
Treated as the 6th coordinate of the Notes:
|
As long as the errors on positions and proper motions are in fact Symmetrical2D for the Gaia case, this should be OK. If one encountered a MANGO instance where e.g. I don't suggest using the language of matrices in the annotations, I was just using it here to explain the structure of the Gaia data. I can build the PDF locally on the branch, so I can see what the amended document looks like. Once the VOTable is updated, I'll revisit my implementation code. |
You are right, once we have decided to split into 3 separate components (vector, corr, error), we delegate to the annotator the responsibility of keeping these components consistent with each other. |
I'd say it's a policy decision about whether this is supposed to be enabling epoch propagation by modelling the Gaia source catalogue, or providing for more general markup of astrometric data. Since epoch propagation in full detail is a somewhat intricate business, I suspect that it will be difficult to come up with a general solution that fits nicely with different missions. But my guess is that a large majority of epoch propagation at this level of detail (errors and correlations) will be Gaia-based or Gaia-like for quite a few years (decades?) to come. Still, it should be feasible to support entry-level epoch propagation (inputs just position, proper motion and epoch difference) for different datasets, and that can work with just a small subset of the existing If you want to retain some generality I think it would be OK to have the ellipse option, though perhaps there should be a note that if A few other points:
|
Thank you, I'll
Next push |
@lmichel the flattened model is now easier for me to work with, thank you, but I think it may not be quite flattened enough to be consistent.
I see some problems with the errors and correlations between sky position and proper motion components.
Section 5.3.3 (
EpochPositionErrors.properMotion
) and 5.3.4 (EpochPositionErrors.Position
) both say:(aside: probably 5.3.4 should say "Proper motion error" here).
But the off-diagonal elements of these correlations/covariances are already dealt with by the items in Sec 5.2 (
EpochPositionCorrelations
), namely the items in subsections 5.2.5 (longitudeLatitude
) and 5.2.6 (pmLongitudePmLatitude
), so if they can be represented underEpochPositionErrors
as well it represents an ambiguity.This point is somewhat related to @mcdittmar's comment on the Gaia example in this thread of the DM list.
Moreover in the gaia_epoch_propagation_flat_full.xml example, the quantities
mango:error.ErrorCorrMatrix.sigma1
andmango:error.ErrorCorrMatrix.sigma2
are quoted with units, although correlation matrices would be dimensionless.What I was expecting for these quantities instead of the two matrix-like items:
was to see four scalar items:
If you agree, corresponding changes would also need to be made in the example.
If 5.3.3 and 5.3.4 are indeed removed/replaced, does this also remove the need for items in the error package, namely sections 9.3 (
ErrorCorrMatrix
), 9.4 (ErrorCovMatrix
) and maybe 9.2 (Ellipse
)?The text was updated successfully, but these errors were encountered: