Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibrationLevel - mapping to ObsCore #70

Open
mcdittmar opened this issue Jan 29, 2025 · 3 comments
Open

CalibrationLevel - mapping to ObsCore #70

mcdittmar opened this issue Jan 29, 2025 · 3 comments

Comments

@mcdittmar
Copy link
Collaborator

The description says this is the enumeration of different possible calibration status of the property as defined by ObsCore.

ObsCore-1.* defines calib_level as an enumerated integer {0,1,2,3,4}.
The definitions in ObsCore Section 3.3.2 match for the first 3, the last 2 are not represented { Raw=0, Instrumental=1, Calibrated=2, =3, =4 }

This model needs to do something since ObsCore is not a VODML model. I think it should match the full ObsCore descriptions, where the number is significant, and the name is the ‘label’. If MANGO PhysicalProperty.calibrationLevel needs to restrict this to (0,1,2) only, it should do so at the attribute and state that the others do not apply in this context.

@lmichel
Copy link
Collaborator

lmichel commented Jan 30, 2025

There is nos a vocabulary for this. The document refer to it now

@lmichel
Copy link
Collaborator

lmichel commented Feb 6, 2025

merged

@mcdittmar
Copy link
Collaborator Author

I like the migration to a vocabulary.. some comments:

  1. this is a draft vocabulary, so tying MANGO to it would require the vocabulary to be approved along with the standard. That's fine, I'm just not sure what state that vocabulary is in.
  2. MANGO should use the base URL (http://www.ivoa.net/rdf/processing-level) rather than the resolved (https://www.ivoa.net/rdf/processing-level/2024-11-12/processing-level.html)
  3. Section 7.1.1 has no 'type' for the attribute. (became NULL with removal of CalibrationLevel I presume)
  4. Section 7.2 section heading for CalibrationLevel still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants