fix(bulk-eval): Fix duplicate row results and detail drawer errors

- Fixed bulk evaluator creating duplicate database records
  - Changed from createRowResult (creates new) to updateRowResult (updates existing)
  - Now properly updates status from 'pending' to 'completed'/'failed'
  - Prevents "pending" status showing when data exists

- Created new API endpoint /api/bulk/row-details
  - Returns row results and original data for detail drawer
  - Accepts run_id and row_index query parameters
  - Added database helper function getRowResultsByIndex()

- Fixed "Failed to fetch row details" error in detail drawer
  - Updated fetchRowDetails() to use new endpoint

- Fixed esbuild syntax error in ResultsTable.astro
  - Converted JSDoc comments to single-line comments in inline script
  - JSDoc comments cause parsing errors with is:inline directive

All quality gates passing (typecheck, lint, format)

Author: ivankristianto

src/components/bulk/ResultsTable.astro

@@ -530,10 +530,8 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
 </div>
 
 <script is:inline define:vars={{ pageSize, csvData }}>
-  /**
-   * Client-side functionality for results table.
-   * Handles pagination, row selection, bulk actions, and per-row actions.
-   */
+  // Client-side functionality for results table.
+  // Handles pagination, row selection, bulk actions, and per-row actions.
 
   let currentPage = 1;
   const totalRows = csvData.length;
@@ -542,9 +540,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
   const selectAllCheckbox = document.getElementById('select-all-rows');
   const paginationInfo = document.getElementById('pagination-info');
 
-  /**
-   * Update checkboxes based on visible rows
-   */
+  // Update checkboxes based on visible rows
   function updateCheckboxes() {
     const rowCheckboxes = document.querySelectorAll('.row-checkbox');
 
@@ -578,9 +574,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     });
   }
 
-  /**
-   * Update bulk action button states based on selection
-   */
+  // Update bulk action button states based on selection
   function updateBulkActionButtons() {
     const selectedCount = getSelectedRows().length;
     const regenerateBtn = document.querySelector('[data-action="regenerate-selected"]');
@@ -594,9 +588,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     }
   }
 
-  /**
-   * Update pagination display and visible rows
-   */
+  // Update pagination display and visible rows
   function updatePagination() {
     const start = (currentPage - 1) * pageSize + 1;
     const end = Math.min(currentPage * pageSize, totalRows);
@@ -635,9 +627,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     }
   }
 
-  /**
-   * Handle page button clicks
-   */
+  // Handle page button clicks
   document.querySelectorAll('[data-page]').forEach((btn) => {
     btn.addEventListener('click', () => {
       const page = parseInt(btn.dataset.page || '1');
@@ -659,9 +649,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     });
   });
 
-  /**
-   * Handle previous page button
-   */
+  // Handle previous page button
   document.querySelector('[data-action="prev-page"]')?.addEventListener('click', () => {
     if (currentPage > 1) {
       currentPage--;
@@ -676,9 +664,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     }
   });
 
-  /**
-   * Handle next page button
-   */
+  // Handle next page button
   document.querySelector('[data-action="next-page"]')?.addEventListener('click', () => {
     if (currentPage < totalPages) {
       currentPage++;
@@ -693,9 +679,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     }
   });
 
-  /**
-   * Handle per-row action clicks
-   */
+  // Handle per-row action clicks
   document.querySelectorAll('[data-action]').forEach((element) => {
     element.addEventListener('click', (e) => {
       e.preventDefault();
@@ -784,9 +768,7 @@ const getActionsLeftOffset = (headerCount: number) => `calc(6rem + ${headerCount
     });
   });
 
-  /**
-   * Get selected row indices
-   */
+  // Get selected row indices
   function getSelectedRows() {
     const rowCheckboxes = document.querySelectorAll('.row-checkbox');
     return Array.from(rowCheckboxes)

src/lib/bulk-evaluation/bulk-evaluator.ts

@@ -19,6 +19,7 @@ import {
   getBulkDataset,
   updateRunStatus,
   createRowResult,
+  updateRowResult,
   getModelById,
   decryptApiKey,
 } from '@lib/db';
@@ -203,9 +204,9 @@ export class BulkEvaluator {
     systemPrompt: string,
     temperature: number
   ): Promise<RowEvaluationResult> {
-    // Create initial pending row result
+    // Create initial pending row result and store its ID
     const prompt = interpolateTemplate(systemPrompt, row);
-    createRowResult({
+    const pendingResult = createRowResult({
       run_id: this.runId,
       original_row_index: rowIndex,
       model_id: modelId,
@@ -245,12 +246,8 @@ export class BulkEvaluator {
         };
       }
 
-      // Update row result with success
-      createRowResult({
-        run_id: this.runId,
-        original_row_index: rowIndex,
-        model_id: modelId,
-        prompt_used: prompt,
+      // Update row result with success (don't create a new one)
+      updateRowResult(pendingResult.id, {
         output_text: modelResponse.response,
         status: 'completed',
         duration_ms: modelResponse.executionTime,
@@ -270,13 +267,9 @@ export class BulkEvaluator {
         error instanceof Error ? error.message : error
       );
 
-      // Update row result with failure
+      // Update row result with failure (don't create a new one)
       const errorMessage = error instanceof Error ? error.message : 'Unknown error';
-      createRowResult({
-        run_id: this.runId,
-        original_row_index: rowIndex,
-        model_id: modelId,
-        prompt_used: prompt,
+      updateRowResult(pendingResult.id, {
         status: 'failed',
         error_message: errorMessage,
       });

src/lib/db/bulk-db.ts

@@ -469,6 +469,25 @@ export function getRowResultForModel(
   return stmt.get(runId, rowIndex, modelId) as RowResult | null;
 }
 
+/**
+ * Get all results for a specific row index in a run.
+ * @param runId - Run ID
+ * @param rowIndex - Original row index
+ * @param db - Optional database instance
+ * @returns Array of row results for all models
+ */
+export function getRowResultsByIndex(
+  runId: string,
+  rowIndex: number,
+  db?: Database.Database
+): RowResult[] {
+  const database = db || getBulkDatabase();
+  const stmt = database.prepare(
+    'SELECT * FROM row_results WHERE run_id = ? AND original_row_index = ? ORDER BY model_id'
+  );
+  return stmt.all(runId, rowIndex) as RowResult[];
+}
+
 /**
  * Update a row result's status and output.
  * @param id - Result ID

src/pages/api/bulk/row-details.ts

@@ -0,0 +1,86 @@
+/**
+ * Bulk Evaluation Row Details API Endpoint
+ * GET /api/bulk/row-details
+ *
+ * Fetches all model results and original row data for a specific row in a bulk evaluation run.
+ * Used by the detail drawer to display comprehensive row information.
+ */
+
+import type { APIRoute } from 'astro';
+import { getRunWithResults, getRowResultsByIndex } from '@lib/db/bulk-db';
+import { badRequest, notFound, createErrorResponse } from '@lib/api-error-handler';
+import { createLogger } from '@lib/logger';
+
+const logger = createLogger('API:Bulk:RowDetails');
+
+/**
+ * GET /api/bulk/row-details?run_id={id}&row_index={index}
+ * Get all results and original data for a specific row
+ *
+ * Query params:
+ *   - run_id (required): The evaluation run ID
+ *   - row_index (required): The row index (0-based)
+ *
+ * Response: 200 with { allRowResults: RowResult[], rowData: Record<string, string> }
+ *          400 with { error: string, code: string }
+ *          404 with { error: string }
+ */
+export const GET: APIRoute = async ({ url }) => {
+  const startTime = Date.now();
+
+  try {
+    const runId = url.searchParams.get('run_id');
+    const rowIndexStr = url.searchParams.get('row_index');
+
+    if (!runId) {
+      logger.logApiRequest('GET', '/api/bulk/row-details', 400, Date.now() - startTime);
+      return badRequest('run_id query parameter is required', 'INVALID_INPUT');
+    }
+
+    if (!rowIndexStr) {
+      logger.logApiRequest('GET', '/api/bulk/row-details', 400, Date.now() - startTime);
+      return badRequest('row_index query parameter is required', 'INVALID_INPUT');
+    }
+
+    const rowIndex = parseInt(rowIndexStr, 10);
+    if (isNaN(rowIndex) || rowIndex < 0) {
+      logger.logApiRequest('GET', '/api/bulk/row-details', 400, Date.now() - startTime);
+      return badRequest('row_index must be a non-negative integer', 'INVALID_INPUT');
+    }
+
+    // Get run with dataset
+    const run = getRunWithResults(runId);
+    if (!run) {
+      logger.logApiRequest('GET', '/api/bulk/row-details', 404, Date.now() - startTime);
+      return notFound('Evaluation run');
+    }
+
+    // Parse CSV data to get the specific row
+    const csvRows = JSON.parse(run.dataset.csv_data) as Record<string, unknown>[];
+    if (rowIndex >= csvRows.length) {
+      logger.logApiRequest('GET', '/api/bulk/row-details', 404, Date.now() - startTime);
+      return notFound('Row data');
+    }
+
+    const rowData = csvRows[rowIndex];
+
+    // Get all results for this row
+    const allRowResults = getRowResultsByIndex(runId, rowIndex);
+
+    logger.logApiRequest('GET', '/api/bulk/row-details', 200, Date.now() - startTime);
+
+    return new Response(
+      JSON.stringify({
+        allRowResults,
+        rowData,
+      }),
+      {
+        status: 200,
+        headers: { 'Content-Type': 'application/json' },
+      }
+    );
+  } catch (error) {
+    logger.logApiError('GET', '/api/bulk/row-details', error as Error);
+    return createErrorResponse(error);
+  }
+};

src/pages/bulk-eval/[id].astro

@@ -329,7 +329,7 @@ const progress = run.total_rows > 0 ? (run.processed_rows / run.total_rows) * 10
     allRowResults: RowResult[];
     rowData: Record<string, string>;
   }> {
-    const response = await fetch(`/api/bulk/result?run_id=${runId}&row_index=${rowIndex}`);
+    const response = await fetch(`/api/bulk/row-details?run_id=${runId}&row_index=${rowIndex}`);
 
     if (!response.ok) {
       throw new Error('Failed to fetch row details');