Grid system #1
Open
Grid system #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarbato
reviewed
Jun 24, 2019
| export const XL = 1720 | ||
| export const L = 1024 | ||
| export const M = 768 | ||
| export const S = 420 |
Contributor
There was a problem hiding this comment.
If you haven't seen the way we are doing this on the styleguide I think it might be something worth bringing into this library
alexbarbato
reviewed
Jun 24, 2019
| NEGATIVE, | ||
| WARNING, | ||
| } | ||
| } from './design-tokens/colors' |
Contributor
There was a problem hiding this comment.
Omg love this change. Thank you
alexbarbato
approved these changes
Jun 24, 2019
Contributor
There was a problem hiding this comment.
Looks great!
My only thoughts are on the breakpoints and I'd personally vote we go more the route of what you see here https://github.com/istrategylabs/mo-styleguide/blob/master/src/utils/breakpoints.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
GridandColumncomponents we know and love from Accion, CTIA, etc. here so that we can (finally!) start reusing them across projects.Library Notes:
Dev Notes:
box-sizing: border-box)