From 3fa31258bfe3586db265fbe36ca93717a14b8d55 Mon Sep 17 00:00:00 2001 From: AdeshGhadage Date: Tue, 4 Feb 2025 18:10:39 +0530 Subject: [PATCH 1/8] update-refdocs-master-brokenUrl --- networking/v1alpha3/destination_rule.proto | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto index 3b86211105..1b941fcbc1 100644 --- a/networking/v1alpha3/destination_rule.proto +++ b/networking/v1alpha3/destination_rule.proto @@ -616,13 +616,13 @@ message ConnectionPoolSettings { message HTTPSettings { // Maximum number of requests that will be queued while waiting for // a ready connection pool connection. Default 2^32-1. - // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking - // under which conditions a new connection is created for HTTP2. - // Please note that this is applicable to both HTTP/1.1 and HTTP2. + // Refer to [Envoy's circuit breaking documentation](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking) + // under which conditions a new connection is created for HTTP/2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. int32 http1_max_pending_requests = 1; // Maximum number of active requests to a destination. Default 2^32-1. - // Please note that this is applicable to both HTTP/1.1 and HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. int32 http2_max_requests = 2; // Maximum number of requests per connection to a backend. Setting this @@ -640,7 +640,7 @@ message ConnectionPoolSettings { // the connection will be closed. If the connection is an HTTP/2 // connection a drain sequence will occur prior to closing the connection. // Note that request based timeouts mean that HTTP/2 PINGs will not - // keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections. + // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. google.protobuf.Duration idle_timeout = 5; // Policy for upgrading http1.1 connections to http2. @@ -685,7 +685,7 @@ message ConnectionPoolSettings { // // The following rule sets a connection pool size of 100 HTTP1 connections // with no more than 10 req/connection to the "reviews" service. In addition, -// it sets a limit of 1000 concurrent HTTP2 requests and configures upstream +// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream // hosts to be scanned every 5 mins so that any host that fails 7 consecutive // times with a 502, 503, or 504 error code will be ejected for 15 minutes. // From 1760bff94980eeb473cb99f008e3efa7ac056b40 Mon Sep 17 00:00:00 2001 From: AdeshGhadage Date: Tue, 4 Feb 2025 18:40:54 +0530 Subject: [PATCH 2/8] update-refdocs-release-1.24-brokenUrl --- networking/v1alpha3/destination_rule.proto | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto index 1b941fcbc1..4eb740b654 100644 --- a/networking/v1alpha3/destination_rule.proto +++ b/networking/v1alpha3/destination_rule.proto @@ -139,7 +139,7 @@ option go_package = "istio.io/api/networking/v1alpha3"; // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. // Clients may not set this value. It is represented in RFC3339 form and is in UTC. -// Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata" +// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)" // +cue-gen:DestinationRule:preserveUnknownFields:false // --> // @@ -278,7 +278,7 @@ message TrafficPolicy { // ⁣PROXY protocol version 2. Binary format. V2 = 1; }; - // The PROXY protocol version to use. See https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt for details. + // The PROXY protocol version to use. See [HAProxy Proxy Protocol](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details. // By default it is `V1`. VERSION version = 1; } @@ -480,8 +480,8 @@ message LoadBalancerSettings { }; // The hash algorithm to use. - // Please refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash - // and https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev for + // Please refer to [Envoy Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash) + // and [Envoy Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) for // considerations on choosing an algorithm. // Defaults to RingHash if not specified. oneof hash_algorithm { @@ -616,6 +616,9 @@ message ConnectionPoolSettings { message HTTPSettings { // Maximum number of requests that will be queued while waiting for // a ready connection pool connection. Default 2^32-1. + // Refer to (Envoy Circuit Breaking)[https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking] + // under which conditions a new connection is created for HTTP/2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. // Refer to [Envoy's circuit breaking documentation](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking) // under which conditions a new connection is created for HTTP/2. // Please note that this is applicable to both HTTP/1.1 and HTTP/2. @@ -623,6 +626,7 @@ message ConnectionPoolSettings { // Maximum number of active requests to a destination. Default 2^32-1. // Please note that this is applicable to both HTTP/1.1 and HTTP/2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. int32 http2_max_requests = 2; // Maximum number of requests per connection to a backend. Setting this @@ -641,6 +645,7 @@ message ConnectionPoolSettings { // connection a drain sequence will occur prior to closing the connection. // Note that request based timeouts mean that HTTP/2 PINGs will not // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. + // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. google.protobuf.Duration idle_timeout = 5; // Policy for upgrading http1.1 connections to http2. @@ -686,6 +691,7 @@ message ConnectionPoolSettings { // The following rule sets a connection pool size of 100 HTTP1 connections // with no more than 10 req/connection to the "reviews" service. In addition, // it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream +// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream // hosts to be scanned every 5 mins so that any host that fails 7 consecutive // times with a 502, 503, or 504 error code will be ejected for 15 minutes. // From 104b863b82b8530fa0869a058077d47bbbe21af0 Mon Sep 17 00:00:00 2001 From: AdeshGhadage Date: Tue, 4 Feb 2025 18:40:54 +0530 Subject: [PATCH 3/8] updatedoc --- networking/v1alpha3/destination_rule.proto | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto index 4eb740b654..397b4fc6b1 100644 --- a/networking/v1alpha3/destination_rule.proto +++ b/networking/v1alpha3/destination_rule.proto @@ -616,17 +616,13 @@ message ConnectionPoolSettings { message HTTPSettings { // Maximum number of requests that will be queued while waiting for // a ready connection pool connection. Default 2^32-1. - // Refer to (Envoy Circuit Breaking)[https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking] - // under which conditions a new connection is created for HTTP/2. - // Please note that this is applicable to both HTTP/1.1 and HTTP/2. - // Refer to [Envoy's circuit breaking documentation](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking) + // Refer to [Envoy Circuit Breaking](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking) // under which conditions a new connection is created for HTTP/2. // Please note that this is applicable to both HTTP/1.1 and HTTP/2. int32 http1_max_pending_requests = 1; // Maximum number of active requests to a destination. Default 2^32-1. // Please note that this is applicable to both HTTP/1.1 and HTTP/2. - // Please note that this is applicable to both HTTP/1.1 and HTTP/2. int32 http2_max_requests = 2; // Maximum number of requests per connection to a backend. Setting this @@ -645,7 +641,6 @@ message ConnectionPoolSettings { // connection a drain sequence will occur prior to closing the connection. // Note that request based timeouts mean that HTTP/2 PINGs will not // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. - // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. google.protobuf.Duration idle_timeout = 5; // Policy for upgrading http1.1 connections to http2. @@ -691,7 +686,6 @@ message ConnectionPoolSettings { // The following rule sets a connection pool size of 100 HTTP1 connections // with no more than 10 req/connection to the "reviews" service. In addition, // it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream -// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream // hosts to be scanned every 5 mins so that any host that fails 7 consecutive // times with a 502, 503, or 504 error code will be ejected for 15 minutes. // From f11bc203c039e5601c721051b346b231d7039795 Mon Sep 17 00:00:00 2001 From: AdeshGhadage Date: Wed, 5 Feb 2025 16:31:07 +0530 Subject: [PATCH 4/8] Regenerate API docs after changes --- kubernetes/customresourcedefinitions.gen.yaml | 6 +++--- networking/v1/destination_rule_alias.gen.go | 4 ++-- networking/v1alpha3/destination_rule.pb.go | 20 +++++++++---------- networking/v1alpha3/destination_rule.pb.html | 14 ++++++------- .../v1beta1/destination_rule_alias.gen.go | 4 ++-- 5 files changed, 24 insertions(+), 24 deletions(-) diff --git a/kubernetes/customresourcedefinitions.gen.yaml b/kubernetes/customresourcedefinitions.gen.yaml index 376511fd60..6ab33fd7fd 100644 --- a/kubernetes/customresourcedefinitions.gen.yaml +++ b/kubernetes/customresourcedefinitions.gen.yaml @@ -393,7 +393,7 @@ spec: when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for - lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata' + lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)' jsonPath: .metadata.creationTimestamp name: Age type: date @@ -2307,7 +2307,7 @@ spec: when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for - lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata' + lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)' jsonPath: .metadata.creationTimestamp name: Age type: date @@ -4221,7 +4221,7 @@ spec: when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for - lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata' + lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)' jsonPath: .metadata.creationTimestamp name: Age type: date diff --git a/networking/v1/destination_rule_alias.gen.go b/networking/v1/destination_rule_alias.gen.go index 000b587370..51e0ec1f70 100644 --- a/networking/v1/destination_rule_alias.gen.go +++ b/networking/v1/destination_rule_alias.gen.go @@ -18,7 +18,7 @@ import "istio.io/api/networking/v1alpha3" // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. // Clients may not set this value. It is represented in RFC3339 form and is in UTC. -// Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata" +// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)" // +cue-gen:DestinationRule:preserveUnknownFields:false // --> // @@ -284,7 +284,7 @@ const ConnectionPoolSettings_HTTPSettings_UPGRADE ConnectionPoolSettings_HTTPSet // // The following rule sets a connection pool size of 100 HTTP1 connections // with no more than 10 req/connection to the "reviews" service. In addition, -// it sets a limit of 1000 concurrent HTTP2 requests and configures upstream +// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream // hosts to be scanned every 5 mins so that any host that fails 7 consecutive // times with a 502, 503, or 504 error code will be ejected for 15 minutes. // diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go index d17e612fb8..a6ab801eb6 100644 --- a/networking/v1alpha3/destination_rule.pb.go +++ b/networking/v1alpha3/destination_rule.pb.go @@ -401,7 +401,7 @@ func (ClientTLSSettings_TLSmode) EnumDescriptor() ([]byte, []int) { // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. // Clients may not set this value. It is represented in RFC3339 form and is in UTC. -// Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata" +// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)" // +cue-gen:DestinationRule:preserveUnknownFields:false // --> // @@ -1074,7 +1074,7 @@ func (x *ConnectionPoolSettings) GetHttp() *ConnectionPoolSettings_HTTPSettings // // The following rule sets a connection pool size of 100 HTTP1 connections // with no more than 10 req/connection to the "reviews" service. In addition, -// it sets a limit of 1000 concurrent HTTP2 requests and configures upstream +// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream // hosts to be scanned every 5 mins so that any host that fails 7 consecutive // times with a 502, 503, or 504 error code will be ejected for 15 minutes. // @@ -1837,7 +1837,7 @@ func (x *TrafficPolicy_TunnelSettings) GetTargetPort() uint32 { type TrafficPolicy_ProxyProtocol struct { state protoimpl.MessageState `protogen:"open.v1"` - // The PROXY protocol version to use. See https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt for details. + // The PROXY protocol version to use. See [HAProxy Proxy Protocol](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details. // By default it is `V1`. Version TrafficPolicy_ProxyProtocol_VERSION `protobuf:"varint,1,opt,name=version,proto3,enum=istio.networking.v1alpha3.TrafficPolicy_ProxyProtocol_VERSION" json:"version,omitempty"` unknownFields protoimpl.UnknownFields @@ -1909,8 +1909,8 @@ type LoadBalancerSettings_ConsistentHashLB struct { // *LoadBalancerSettings_ConsistentHashLB_HttpQueryParameterName HashKey isLoadBalancerSettings_ConsistentHashLB_HashKey `protobuf_oneof:"hash_key"` // The hash algorithm to use. - // Please refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash - // and https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev for + // Please refer to [Envoy Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash) + // and [Envoy Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) for // considerations on choosing an algorithm. // Defaults to RingHash if not specified. // @@ -2353,12 +2353,12 @@ type ConnectionPoolSettings_HTTPSettings struct { state protoimpl.MessageState `protogen:"open.v1"` // Maximum number of requests that will be queued while waiting for // a ready connection pool connection. Default 2^32-1. - // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking - // under which conditions a new connection is created for HTTP2. - // Please note that this is applicable to both HTTP/1.1 and HTTP2. + // Refer to [Envoy Circuit Breaking](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking) + // under which conditions a new connection is created for HTTP/2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. Http1MaxPendingRequests int32 `protobuf:"varint,1,opt,name=http1_max_pending_requests,json=http1MaxPendingRequests,proto3" json:"http1_max_pending_requests,omitempty"` // Maximum number of active requests to a destination. Default 2^32-1. - // Please note that this is applicable to both HTTP/1.1 and HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP/2. Http2MaxRequests int32 `protobuf:"varint,2,opt,name=http2_max_requests,json=http2MaxRequests,proto3" json:"http2_max_requests,omitempty"` // Maximum number of requests per connection to a backend. Setting this // parameter to 1 disables keep alive. Default 0, meaning "unlimited", @@ -2373,7 +2373,7 @@ type ConnectionPoolSettings_HTTPSettings struct { // the connection will be closed. If the connection is an HTTP/2 // connection a drain sequence will occur prior to closing the connection. // Note that request based timeouts mean that HTTP/2 PINGs will not - // keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections. + // keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections. IdleTimeout *duration.Duration `protobuf:"bytes,5,opt,name=idle_timeout,json=idleTimeout,proto3" json:"idle_timeout,omitempty"` // Specify if http1.1 connection should be upgraded to http2 for the associated destination. H2UpgradePolicy ConnectionPoolSettings_HTTPSettings_H2UpgradePolicy `protobuf:"varint,6,opt,name=h2_upgrade_policy,json=h2UpgradePolicy,proto3,enum=istio.networking.v1alpha3.ConnectionPoolSettings_HTTPSettings_H2UpgradePolicy" json:"h2_upgrade_policy,omitempty"` diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html index feff89e79f..d548fc45fb 100644 --- a/networking/v1alpha3/destination_rule.pb.html +++ b/networking/v1alpha3/destination_rule.pb.html @@ -398,7 +398,7 @@

ProxyProtocol

VERSION
-

The PROXY protocol version to use. See https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt for details. +

The PROXY protocol version to use. See HAProxy Proxy Protocol for details. By default it is V1.

@@ -1102,9 +1102,9 @@

HTTPSettings

Maximum number of requests that will be queued while waiting for a ready connection pool connection. Default 2^32-1. -Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking -under which conditions a new connection is created for HTTP2. -Please note that this is applicable to both HTTP/1.1 and HTTP2.

+Refer to Envoy Circuit Breaking +under which conditions a new connection is created for HTTP/2. +Please note that this is applicable to both HTTP/1.1 and HTTP/2.

@@ -1114,7 +1114,7 @@

HTTPSettings

Maximum number of active requests to a destination. Default 2^32-1. -Please note that this is applicable to both HTTP/1.1 and HTTP2.

+Please note that this is applicable to both HTTP/1.1 and HTTP/2.

@@ -1150,7 +1150,7 @@

HTTPSettings

the connection will be closed. If the connection is an HTTP/2 connection a drain sequence will occur prior to closing the connection. Note that request based timeouts mean that HTTP/2 PINGs will not -keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections.

+keep the connection alive. Applies to both HTTP/1.1 and HTTP/2 connections.

@@ -1238,7 +1238,7 @@

OutlierDetection

for more details.

The following rule sets a connection pool size of 100 HTTP1 connections with no more than 10 req/connection to the “reviews” service. In addition, -it sets a limit of 1000 concurrent HTTP2 requests and configures upstream +it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream hosts to be scanned every 5 mins so that any host that fails 7 consecutive times with a 502, 503, or 504 error code will be ejected for 15 minutes.

apiVersion: networking.istio.io/v1
diff --git a/networking/v1beta1/destination_rule_alias.gen.go b/networking/v1beta1/destination_rule_alias.gen.go
index 1981af3649..1ee75ec7c7 100644
--- a/networking/v1beta1/destination_rule_alias.gen.go
+++ b/networking/v1beta1/destination_rule_alias.gen.go
@@ -18,7 +18,7 @@ import "istio.io/api/networking/v1alpha3"
 // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp
 // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations.
 // Clients may not set this value. It is represented in RFC3339 form and is in UTC.
-// Populated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata"
+// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)"
 // +cue-gen:DestinationRule:preserveUnknownFields:false
 // -->
 //
@@ -284,7 +284,7 @@ const ConnectionPoolSettings_HTTPSettings_UPGRADE ConnectionPoolSettings_HTTPSet
 //
 // The following rule sets a connection pool size of 100 HTTP1 connections
 // with no more than 10 req/connection to the "reviews" service. In addition,
-// it sets a limit of 1000 concurrent HTTP2 requests and configures upstream
+// it sets a limit of 1000 concurrent HTTP/2 requests and configures upstream
 // hosts to be scanned every 5 mins so that any host that fails 7 consecutive
 // times with a 502, 503, or 504 error code will be ejected for 15 minutes.
 //

From c35114adbb5a43448ccb55cd97ee03b1e8c152a9 Mon Sep 17 00:00:00 2001
From: Adesh Ghadage <110734052+AdeshGhadage@users.noreply.github.com>
Date: Thu, 6 Feb 2025 22:34:46 +0530
Subject: [PATCH 5/8] Update networking/v1alpha3/destination_rule.proto

Co-authored-by: Craig Box 
---
 networking/v1alpha3/destination_rule.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index 397b4fc6b1..1b4d9a01c2 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -139,7 +139,7 @@ option go_package = "istio.io/api/networking/v1alpha3";
 // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp
 // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations.
 // Clients may not set this value. It is represented in RFC3339 form and is in UTC.
-// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)"
+// Populated by the system. Read-only. Null for lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)"
 // +cue-gen:DestinationRule:preserveUnknownFields:false
 // -->
 //

From 7d91eb9bf47a60f1c72d496083a91f343ea5405e Mon Sep 17 00:00:00 2001
From: Adesh Ghadage <110734052+AdeshGhadage@users.noreply.github.com>
Date: Thu, 6 Feb 2025 22:34:57 +0530
Subject: [PATCH 6/8] Update networking/v1alpha3/destination_rule.proto

Co-authored-by: Craig Box 
---
 networking/v1alpha3/destination_rule.proto | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index 1b4d9a01c2..7bd87b2e2b 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -278,7 +278,7 @@ message TrafficPolicy {
       // ⁣PROXY protocol version 2. Binary format.
       V2 = 1;
     };
-    // The PROXY protocol version to use. See [HAProxy Proxy Protocol](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details.
+    // The PROXY protocol version to use. See [the protocol spec](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details.
     // By default it is `V1`.
     VERSION version = 1;
   }

From 633fe62305eea8ee984d3c93d58dee7a680c46fa Mon Sep 17 00:00:00 2001
From: Adesh Ghadage <110734052+AdeshGhadage@users.noreply.github.com>
Date: Thu, 6 Feb 2025 22:35:04 +0530
Subject: [PATCH 7/8] Update networking/v1alpha3/destination_rule.proto

Co-authored-by: Craig Box 
---
 networking/v1alpha3/destination_rule.proto | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index 7bd87b2e2b..da34139337 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -480,8 +480,8 @@ message LoadBalancerSettings {
     };
 
         // The hash algorithm to use.
-        // Please refer to [Envoy Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash)
-        // and [Envoy Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) for
+        // Please refer to Envoy's [Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash)
+        // and [Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) docs for
         // considerations on choosing an algorithm.
         // Defaults to RingHash if not specified.
         oneof hash_algorithm {

From 4e6e3aa38bb8813e31aba7c83f0ef346b9c823a6 Mon Sep 17 00:00:00 2001
From: AdeshGhadage 
Date: Thu, 6 Feb 2025 22:48:18 +0530
Subject: [PATCH 8/8] Updated refdoc

---
 kubernetes/customresourcedefinitions.gen.yaml  | 18 +++++++++---------
 networking/v1/destination_rule_alias.gen.go    |  2 +-
 networking/v1alpha3/destination_rule.pb.go     |  8 ++++----
 networking/v1alpha3/destination_rule.pb.html   |  2 +-
 .../v1beta1/destination_rule_alias.gen.go      |  2 +-
 5 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/kubernetes/customresourcedefinitions.gen.yaml b/kubernetes/customresourcedefinitions.gen.yaml
index 6ab33fd7fd..f4d8b6006c 100644
--- a/kubernetes/customresourcedefinitions.gen.yaml
+++ b/kubernetes/customresourcedefinitions.gen.yaml
@@ -389,11 +389,11 @@ spec:
       jsonPath: .spec.host
       name: Host
       type: string
-    - description: 'CreationTimestamp is a timestamp representing the server time
-        when this object was created. It is not guaranteed to be set in happens-before
+    - description: CreationTimestamp is a timestamp representing the server time when
+        this object was created. It is not guaranteed to be set in happens-before
         order across separate operations. Clients may not set this value. It is represented
         in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for
-        lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)'
+        lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)
       jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
@@ -2303,11 +2303,11 @@ spec:
       jsonPath: .spec.host
       name: Host
       type: string
-    - description: 'CreationTimestamp is a timestamp representing the server time
-        when this object was created. It is not guaranteed to be set in happens-before
+    - description: CreationTimestamp is a timestamp representing the server time when
+        this object was created. It is not guaranteed to be set in happens-before
         order across separate operations. Clients may not set this value. It is represented
         in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for
-        lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)'
+        lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)
       jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
@@ -4217,11 +4217,11 @@ spec:
       jsonPath: .spec.host
       name: Host
       type: string
-    - description: 'CreationTimestamp is a timestamp representing the server time
-        when this object was created. It is not guaranteed to be set in happens-before
+    - description: CreationTimestamp is a timestamp representing the server time when
+        this object was created. It is not guaranteed to be set in happens-before
         order across separate operations. Clients may not set this value. It is represented
         in RFC3339 form and is in UTC. Populated by the system. Read-only. Null for
-        lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)'
+        lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)
       jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
diff --git a/networking/v1/destination_rule_alias.gen.go b/networking/v1/destination_rule_alias.gen.go
index 51e0ec1f70..564a122a34 100644
--- a/networking/v1/destination_rule_alias.gen.go
+++ b/networking/v1/destination_rule_alias.gen.go
@@ -18,7 +18,7 @@ import "istio.io/api/networking/v1alpha3"
 // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp
 // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations.
 // Clients may not set this value. It is represented in RFC3339 form and is in UTC.
-// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)"
+// Populated by the system. Read-only. Null for lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)"
 // +cue-gen:DestinationRule:preserveUnknownFields:false
 // -->
 //
diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go
index a6ab801eb6..bf0075196c 100644
--- a/networking/v1alpha3/destination_rule.pb.go
+++ b/networking/v1alpha3/destination_rule.pb.go
@@ -401,7 +401,7 @@ func (ClientTLSSettings_TLSmode) EnumDescriptor() ([]byte, []int) {
 // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp
 // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations.
 // Clients may not set this value. It is represented in RFC3339 form and is in UTC.
-// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)"
+// Populated by the system. Read-only. Null for lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)"
 // +cue-gen:DestinationRule:preserveUnknownFields:false
 // -->
 //
@@ -1837,7 +1837,7 @@ func (x *TrafficPolicy_TunnelSettings) GetTargetPort() uint32 {
 
 type TrafficPolicy_ProxyProtocol struct {
 	state protoimpl.MessageState `protogen:"open.v1"`
-	// The PROXY protocol version to use. See [HAProxy Proxy Protocol](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details.
+	// The PROXY protocol version to use. See [the protocol spec](https://www.haproxy.org/download/2.1/doc/proxy-protocol.txt) for details.
 	// By default it is `V1`.
 	Version       TrafficPolicy_ProxyProtocol_VERSION `protobuf:"varint,1,opt,name=version,proto3,enum=istio.networking.v1alpha3.TrafficPolicy_ProxyProtocol_VERSION" json:"version,omitempty"`
 	unknownFields protoimpl.UnknownFields
@@ -1909,8 +1909,8 @@ type LoadBalancerSettings_ConsistentHashLB struct {
 	//	*LoadBalancerSettings_ConsistentHashLB_HttpQueryParameterName
 	HashKey isLoadBalancerSettings_ConsistentHashLB_HashKey `protobuf_oneof:"hash_key"`
 	// The hash algorithm to use.
-	// Please refer to [Envoy Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash)
-	// and [Envoy Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) for
+	// Please refer to Envoy's [Ring Hash Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#ring-hash)
+	// and [Maglev Load Balancer](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/load_balancers#maglev) docs for
 	// considerations on choosing an algorithm.
 	// Defaults to RingHash if not specified.
 	//
diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html
index d548fc45fb..a5b21c4664 100644
--- a/networking/v1alpha3/destination_rule.pb.html
+++ b/networking/v1alpha3/destination_rule.pb.html
@@ -398,7 +398,7 @@ 
ProxyProtocol

 
VERSION

 
 
-
The PROXY protocol version to use. See HAProxy Proxy Protocol for details.
+
The PROXY protocol version to use. See the protocol spec for details.
 By default it is V1.

 
 
diff --git a/networking/v1beta1/destination_rule_alias.gen.go b/networking/v1beta1/destination_rule_alias.gen.go
index 1ee75ec7c7..1a5a7f38c2 100644
--- a/networking/v1beta1/destination_rule_alias.gen.go
+++ b/networking/v1beta1/destination_rule_alias.gen.go
@@ -18,7 +18,7 @@ import "istio.io/api/networking/v1alpha3"
 // +cue-gen:DestinationRule:printerColumn:name=Age,type=date,JSONPath=.metadata.creationTimestamp,description="CreationTimestamp is a timestamp
 // representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations.
 // Clients may not set this value. It is represented in RFC3339 form and is in UTC.
-// Populated by the system. Read-only. Null for lists. More info: [K8s API Conventions](https://git.k8s.io/community/contributors/devel/api-conventions.md#metadata)"
+// Populated by the system. Read-only. Null for lists. For more information, see [Kubernetes API Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#metadata)"
 // +cue-gen:DestinationRule:preserveUnknownFields:false
 // -->
 //