Skip to content

Commit d0b40a1

Browse files
committed
Revert non-serviceentry related changes
1 parent 31b8e88 commit d0b40a1

File tree

9 files changed

+12
-62
lines changed

9 files changed

+12
-62
lines changed

networking/v1alpha3/service_entry.pb.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.pb.html

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.proto

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ message ServiceEntry {
465465
// service accounts associated with the pods of the service, the
466466
// SANs specified here will also be verified.
467467
//
468-
// **NOTE 3:** Ambient mode does not support wildcard hostsnames.
468+
// **NOTE 3:** Ztunnel and Waypoint proxies does not support wildcard hostnames.
469469
//
470470
// +kubebuilder:validation:MinItems=1
471471
// +kubebuilder:validation:MaxItems=256
@@ -599,8 +599,7 @@ message ServiceEntry {
599599
// the annotation "networking.istio.io/exportTo" to a comma-separated list
600600
// of namespace names.
601601
//
602-
// **Note:** Ambient mode does not support this field. Service entries will
603-
// be exported to all namespaces.
602+
// **Note:** Ztunnel and Waypoint proxies not support this field and will read it at "*"
604603
repeated string export_to = 7;
605604

606605
// If specified, the proxy will verify that the server certificate's

networking/v1alpha3/sidecar.pb.go

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/sidecar.pb.html

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/sidecar.proto

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,8 @@ syntax = "proto3";
2121
// $aliases: [/docs/reference/config/networking/v1alpha3/sidecar]
2222

2323
// `Sidecar` describes the configuration of the sidecar proxy that mediates
24-
// inbound and outbound communication to the workload instance it is attached to.
25-
// `Sidecar` only applies to Sidecar mode.
26-
// By default, Istio will program all sidecar proxies in the mesh with the
24+
// inbound and outbound communication to the workload instance it is attached to. By
25+
// default, Istio will program all sidecar proxies in the mesh with the
2726
// necessary configuration required to reach every workload instance in the mesh, as
2827
// well as accept traffic on all the ports associated with the
2928
// workload. The `Sidecar` configuration provides a way to fine tune the set of

networking/v1alpha3/virtual_service.pb.go

Lines changed: 0 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,6 @@ syntax = "proto3";
5757
// The source of traffic can also be matched in a routing rule. This allows routing
5858
// to be customized for specific client contexts.
5959
//
60-
// *Note for Ambient Users*: Support for `VirtualService` in Ambient mode is alpha, and
61-
// there are no plans to increase support.
62-
// Use [Gateway API](https://istio.io/latest/docs/tasks/traffic-management/ingress/gateway-api/#mesh-traffic)
63-
// for a stable traffic management API.
64-
//
6560
// The following example on Kubernetes, routes all HTTP traffic by default to
6661
// pods of the reviews service with label "version: v1". In addition,
6762
// HTTP requests with path starting with /wpcatalog/ or /consumercatalog/ will
@@ -823,8 +818,6 @@ message HTTPMatchRequest {
823818
//
824819
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
825820
// VirtualService applies to.
826-
//
827-
// **Note:** Ambient mode does not support this field.
828821
map<string, string> source_labels = 7;
829822

830823
// Names of gateways where the rule should be applied. Gateway names
@@ -866,8 +859,6 @@ message HTTPMatchRequest {
866859
//
867860
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
868861
// VirtualService applies to.
869-
//
870-
// **Note:** Ambient mode does not support this field.
871862
string source_namespace = 13;
872863

873864
// The human readable prefix to use when emitting statistics for this route.
@@ -999,8 +990,6 @@ message L4MatchAttributes {
999990
//
1000991
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
1001992
// VirtualService applies to.
1002-
//
1003-
// **Note:** Ambient mode does not support this field.
1004993
map<string, string> source_labels = 4;
1005994

1006995
// Names of gateways where the rule should be applied. Gateway names
@@ -1014,8 +1003,6 @@ message L4MatchAttributes {
10141003
//
10151004
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10161005
// VirtualService applies to.
1017-
//
1018-
// **Note:** Ambient mode does not support this field.
10191006
string source_namespace = 6;
10201007
}
10211008

@@ -1047,8 +1034,6 @@ message TLSMatchAttributes {
10471034
//
10481035
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10491036
// VirtualService applies to.
1050-
//
1051-
// **Note:** Ambient mode does not support this field.
10521037
map<string, string> source_labels = 5;
10531038

10541039
// Names of gateways where the rule should be applied. Gateway names
@@ -1062,8 +1047,6 @@ message TLSMatchAttributes {
10621047
//
10631048
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10641049
// VirtualService applies to.
1065-
//
1066-
// **Note:** Ambient mode does not support this field.
10671050
string source_namespace = 7;
10681051
}
10691052

0 commit comments

Comments
 (0)