Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MyPy compatibility #324

Open
webknjaz opened this issue Aug 19, 2024 · 4 comments
Open

Implement MyPy compatibility #324

webknjaz opened this issue Aug 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@webknjaz
Copy link

I'm hitting "Overall lines covered not found" (https://github.com/irongut/CodeCoverageSummary/blob/f138489/src/CodeCoverageSummary/Program.cs#L172C41-L172C74) when trying to display coverage data produced by the most used Python type checker — MyPy.

It's generated using the --cobertura-xml-report CLI flag per https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-cobertura-xml-report.

To grab an example, go to https://app.codecov.io/github/aio-libs/yarl/commit/1fe1e02357537b5cf348b2088bcedb30847fbbf9, find an upload with the MyPy flag in the widget on the right, click Download. You'll get the payload sent to the Codecov service. The beginning on the text is just a list of files, so scroll down to the <<<<<< network delimiter and you'll see the XML under it.

@webknjaz
Copy link
Author

I also filed an issue over @ MyPy, as it seems to be violating the spec: python/mypy#17689.

@webknjaz
Copy link
Author

So python/mypy#17738 has been merged yesterday. Once it gets released, we'll be able to re-test the compatibility of the produced report.

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 30 days.

@github-actions github-actions bot added the stale label Dec 16, 2024
@webknjaz
Copy link
Author

Looks like this should be fixed in v1.12.0. Just needs to be tested.

@github-actions github-actions bot removed the stale label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Needs triage
Development

No branches or pull requests

2 participants