Merge pull request ethereum#14981 from zo9999/fix-signature-of-function-operator-for-symbolic-function-variable

Pass vector of SMT expressions to SymbolicFunctionVariable function operator by const ref instead of by value.

Author: blishko

libsolidity/formal/SymbolicVariables.cpp

@@ -203,7 +203,7 @@ smtutil::Expression SymbolicFunctionVariable::increaseIndex()
 	return m_abstract.currentValue();
 }
 
-smtutil::Expression SymbolicFunctionVariable::operator()(std::vector<smtutil::Expression> _arguments) const
+smtutil::Expression SymbolicFunctionVariable::operator()(std::vector<smtutil::Expression> const& _arguments) const
 {
 	return m_declaration(_arguments);
 }

libsolidity/formal/SymbolicVariables.h

@@ -62,7 +62,7 @@ class SymbolicVariable
 	virtual smtutil::Expression resetIndex();
 	virtual smtutil::Expression setIndex(unsigned _index);
 	virtual smtutil::Expression increaseIndex();
-	virtual smtutil::Expression operator()(std::vector<smtutil::Expression> /*_arguments*/) const
+	virtual smtutil::Expression operator()(std::vector<smtutil::Expression> const& /*_arguments*/) const
 	{
 		solAssert(false, "Function application to non-function.");
 	}
@@ -177,7 +177,7 @@ class SymbolicFunctionVariable: public SymbolicVariable
 	smtutil::Expression setIndex(unsigned _index) override;
 	smtutil::Expression increaseIndex() override;
 
-	smtutil::Expression operator()(std::vector<smtutil::Expression> _arguments) const override;
+	smtutil::Expression operator()(std::vector<smtutil::Expression> const& _arguments) const override;
 
 private:
 	/// Creates a new function declaration.