Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: superfluous response.WriteHeader under load #10638

Open
lidel opened this issue Dec 21, 2024 · 0 comments
Open

http: superfluous response.WriteHeader under load #10638

lidel opened this issue Dec 21, 2024 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Dec 21, 2024

Error from #7165 (or its variant) seems to be back if a node is under some gateway load.

kubo-staging-us-east-02 running kubo v0.33.0-rc1 (#10580) with boxo v0.26.0 has a lot of these in logs:

Dec 21 05:06:58 kubo-staging-us-east-02 ipfs[488049]: 2024/12/21 05:06:58 http: superfluous response.WriteHeader call from github.com/prometheus/client_golang/prometheus/promhttp.(*responseWriterDelegator).WriteHeader (delegator.go:65)

Did not investigate the source of this one, but it is likely one of http handlers (rpc api, gateway, prometheus metrix exporter?)
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel