Add support for inlining via the id-hash to the add command.

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>

Author: kevina

core/commands/add.go

@@ -44,6 +44,8 @@ const (
 	fstoreCacheOptionName = "fscache"
 	cidVersionOptionName  = "cid-version"
 	hashOptionName        = "hash"
+	inlineOptionName      = "inline"
+	idHashLimitOptionName = "id-hash-limit"
 )
 
 const adderOutChanSize = 8
@@ -120,6 +122,8 @@ You can now check what blocks have been created by:
 		cmdkit.BoolOption(fstoreCacheOptionName, "Check the filestore for pre-existing blocks. (experimental)"),
 		cmdkit.IntOption(cidVersionOptionName, "CID version. Defaults to 0 unless an option that depends on CIDv1 is passed. (experimental)"),
 		cmdkit.StringOption(hashOptionName, "Hash function to use. Implies CIDv1 if not sha2-256. (experimental)").WithDefault("sha2-256"),
+		cmdkit.BoolOption(inlineOptionName, "Inline small objects using identity hash. (experimental)"),
+		cmdkit.IntOption(idHashLimitOptionName, "Identity hash maxium size. (experimental)").WithDefault(64),
 	},
 	PreRun: func(req *cmds.Request, env cmds.Environment) error {
 		quiet, _ := req.Options[quietOptionName].(bool)
@@ -173,6 +177,8 @@ You can now check what blocks have been created by:
 		fscache, _ := req.Options[fstoreCacheOptionName].(bool)
 		cidVer, cidVerSet := req.Options[cidVersionOptionName].(int)
 		hashFunStr, _ := req.Options[hashOptionName].(string)
+		inline, _ := req.Options[inlineOptionName].(bool)
+		idHashLimit, _ := req.Options[idHashLimitOptionName].(int)
 
 		// The arguments are subject to the following constraints.
 		//
@@ -281,6 +287,10 @@ You can now check what blocks have been created by:
 		fileAdder.NoCopy = nocopy
 		fileAdder.Prefix = &prefix
 
+		if inline {
+			fileAdder.Prefix = Inliner{fileAdder.Prefix, idHashLimit}
+		}
+
 		if hash {
 			md := dagtest.Mock()
 			emptyDirNode := ft.EmptyDirNode()

core/commands/inliner.go

@@ -0,0 +1,26 @@
+package commands
+
+import (
+	cid "gx/ipfs/QmYVNvtQkeZ6AKSwDrjQTs432QtL6umrrK41EBq3cu7iSP/go-cid"
+	mh "gx/ipfs/QmPnFwZ2JXKnXgMw8CdBPxn7FWh6LLdjUjxV1fKHuJnkr8/go-multihash"
+)
+
+type Inliner struct {
+	base cid.Format
+	limit int
+}
+
+func (p Inliner) GetCodec() uint64 {
+	return p.base.GetCodec()
+}
+
+func (p Inliner) WithCodec(c uint64) cid.Format {
+	return Inliner{p.base.WithCodec(c), p.limit}
+}
+
+func (p Inliner) Sum(data []byte) (*cid.Cid, error) {
+	if len(data) > p.limit {
+		return p.base.Sum(data)
+	}
+	return cid.FormatV1{Codec: p.base.GetCodec(), HashFun: mh.ID}.Sum(data)
+}

test/sharness/t0046-id-hash.sh

@@ -43,6 +43,26 @@ test_expect_success "can still fetch it" '
   test_cmp junk.txt actual
 '
 
+test_expect_success "ipfs add --inline works as expected" '
+  echo $ID_HASH0_CONTENTS > afile &&
+  HASH=$(ipfs add -q --inline afile)
+'
+
+test_expect_success "ipfs add --inline outputs the correct hash" '
+  echo zrjkGSFoQBjsuadykdx7acCCDAmcLX4HmLUFCs = "$HASH" &&
+  test zrjkGSFoQBjsuadykdx7acCCDAmcLX4HmLUFCs = "$HASH"
+'
+
+test_expect_success "ipfs add --inline --raw-leaves works as expected" '
+  echo $ID_HASH0_CONTENTS > afile &&
+  HASH=$(ipfs add -q --inline --raw-leaves afile)
+'
+
+test_expect_success "ipfs add --inline --raw-leaves outputs the correct hash" '
+  echo "$ID_HASH0" = "$HASH" &&
+  test "$ID_HASH0" = "$HASH"
+'
+
 test_expect_success "enable filestore" '
   ipfs config --json Experimental.FilestoreEnabled true
 '