Skip to content

[Documentation] Files added by webui should not be regarded as pinned #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EliasGabrielsson opened this issue Feb 14, 2019 · 3 comments
Closed
Labels
area/screen/files Issues related to Files screen kind/discussion Topical discussion; usually not changes to codebase

Comments

@EliasGabrielsson
Copy link

EliasGabrielsson commented Feb 14, 2019

Issue:

Files added using the webui does not show up while issuing command: ipfs pin ls. The files show up in the web ui. According to the documentation for the IPFS HTTP CLIENT - API an added file by the webui shall be pinned by default https://github.com/ipfs/interface-js-ipfs-core/blob/master/SPEC/FILES.md#add. This is not correct, explained in this issue: ipfs/kubo#5981 (comment).

Action needed:

  • Documentation needs to be be more stringent about what is stored locally on the machine and not.
  • Maybe even reflect this in the UI somehow. When using the web-ui I thought files added shall be regarded as persistent but that aren't the case apparently.
@EliasGabrielsson EliasGabrielsson changed the title [Documentation] Files added by webui are should not be regarded as pinned [Documentation] Files added by webui should not be regarded as pinned Feb 14, 2019
@olizilla
Copy link
Member

olizilla commented Feb 18, 2019

Files you add via webui are added to your "Mutable File System" (MFS) view over your local blockstore. The MFS view gives you a unix-file-system-like view of things that you can edit, so you can add a file to /my-file.txt to your local MFS view, and under the hood, it is chunked and added to added to the blockstore, and then the root CID is added as a link called myfile.txt from the / directory in your MFS. Because all the things are immutable, the CID for the / folder changes, and that new CID becomes your MFS root, and that CID is pinned along with all locally stored CIDs that it links to.

In this way, files you add to webui are added to your MFS and are pinned, transitively. The individual files you add won't show up in the output of ipfs pin ls, as only the current root CID is pinned.

The files you add via webui are stored locally on your machine and will not be garbage collected if you have that enabled.

We need to simplify the model of how the blockstore, pins and the MFS interact, so it's more obvious to folks. In the meantime @EliasGabrielsson, do you have any thoughts on how we could clarify the docs or UI to better show this?

@olizilla olizilla added kind/discussion Topical discussion; usually not changes to codebase area/screen/files Issues related to Files screen labels Feb 18, 2019
@akledirs
Copy link

Maybe show sign "Pinned" in WebUI or do note about this for users? I few days search info about fact pinning my files in webui. Thanks this issue now know.

@lidel
Copy link
Member

lidel commented Feb 11, 2022

Closing, as a lot happened since 2019:

Any follow-ups should happen in new issues.

@lidel lidel closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

4 participants