Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failing #973

Closed
hacdias opened this issue Jul 14, 2019 · 4 comments
Closed

CI Failing #973

hacdias opened this issue Jul 14, 2019 · 4 comments
Labels
P0 Critical: Tackled by core team ASAP

Comments

@hacdias
Copy link
Member

hacdias commented Jul 14, 2019

CI is failing, mostly Travis with time outs downloading Web UI or go-ipfs from the gateway.

@hacdias hacdias added the P0 Critical: Tackled by core team ASAP label Jul 14, 2019
@hacdias
Copy link
Member Author

hacdias commented Jul 24, 2019

It seems IPFS Companion is moving from an hard-coded Web UI version to using the bundled version with the implementation (see ipfs/ipfs-companion#736). Moving on that path here would solve this CI issue.

Although, IPFS Desktop depends on IPFS Web UI even when the daemon is offline: it needs the settings page to be always available so we can't just load it from the daemon. One solution, and since all of our settings are checkboxes, would be to move them to the menubar itself.

Another solution is to keep Desktop tied to a release of Web UI and somehow fix what's going on on the CI: it's failing to download the Web UI from the gateway by timing out.

Suggestions @olizilla @lidel?

@olizilla
Copy link
Member

The highest priority is to improve the response time from the gateway.

@hacdias
Copy link
Member Author

hacdias commented Jul 24, 2019

@olizilla in the meanwhile, I'll probably update ipfs-or-gateway to make multiple tries (maybe 3 and configurable) because it sometimes works right after trying again, which is weird IMO, but I'll try that.

@lidel
Copy link
Member

lidel commented Jul 24, 2019

@hacdias it could also fallback to other "trusted" public gateway, eg. https://cloudflare-ipfs.com, to mitigate scenarios where only our GW is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

3 participants