Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect/update if local gateway port changes in config #1765

Open
promeneur opened this issue Jan 24, 2021 · 3 comments · May be fixed by collisioncataclysm/ipfs-desktop#1
Open
Labels
kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met

Comments

@promeneur
Copy link

Describe the bug
when ipfs local gateway changes the port 8080 to 8081 then FF ipfs companion does not change port 8080 to 8081

To Reproduce
Steps to reproduce the behavior:

  1. launch vlc using port 8080 for remote control
  2. launch ipfs-desktop
  3. ipfs-desktop offers to change to 8081
  4. i accept
    5 i launch FF then i click on ipfs companion
  5. i see that local gateway port is still 8080

Expected behavior
in ipfs companion local gateway port automatically changes to 8081

Desktop (please complete the following information):

  • openSuse 15.2
  • Firefox 84.0.2, ipfs companion 2.17.2
  • snap packet ipfs-desktop 0.13.2
@jessicaschilling
Copy link
Contributor

Thanks - the core team will discuss in our next triage, but please be aware in the meantime that this can be changed manually in Companion's settings page.

@jessicaschilling jessicaschilling changed the title when ipfs local gateway changes the port 8080 to 8081 then FF ipfs companion does not change port 8080 to 8081 Automatically detect/update if local gateway port changes in config Jan 25, 2021
@jessicaschilling
Copy link
Contributor

Let's use this issue to investigate how hacky/costly it would be for Companion to "know" if the local gateway port changes, and act accordingly. It's a common frustration for anyone who, for example:

  1. Is doing any of the myriad tasks that already claim the commonly-used port 8080
  2. Starts IPFS (in this example, Desktop)
  3. Gets the Desktop alert that the port is in use, changes port
  4. Forgets all about this until tries to open an IPFS-hosted artifact in a Companion-enabled browser, and then gets a very generic error

@aschmahmann aschmahmann transferred this issue from ipfs/ipfs-companion Feb 22, 2021
@lidel lidel removed their assignment May 19, 2021
@lidel lidel added the need/triage Needs initial labeling and prioritization label May 19, 2021
@ipfs ipfs deleted a comment from welcome bot Jun 18, 2021
@lidel
Copy link
Member

lidel commented Jun 18, 2021

Companion is polling peer list, we could additionally/instead read subset of config with gateway port.
This most likely needs ipfs/ipfs-companion#721 (comment) to land first tho.

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met and removed need/triage Needs initial labeling and prioritization labels Jun 18, 2021
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/blocked Unable to be worked further until needs are met
Projects
No open projects
Status: Needs Grooming
Development

Successfully merging a pull request may close this issue.

3 participants