Support for Microsoft Edge?

[lidel]

Good question :) There is an open task in #276 for smoke-testing it under MS Edge, but nobody picked it up yet (most of our community seems to be using Firefox/Chrome).

@rogersachan do you have MS Edge and some spare time on your hands? If so, try loading ipfs_companion-2.1.0.zip (see this instruction) and let us know if there were any errors (AFAIK Edge does not support notifications API yet, so you may need to inspect Browser Console).

It would be an important data point telling us where MS Edge stands.

I get an error before I can even load this extension. There are no other errors or messages in the console.

Updating background with this in order to fix the issue gives me another error.

Deleting both 'browser_style' fields allowed me to import the extension. I'll start testing it as soon as I can.

Attempting any of the links in #312 just sends me to the search engine.

The background page is now giving me this error:

Unable to initialize addon due to error Error: Invocation of form storage.local.get(object) doesn't match definition storage.local.get(optional string or array or object keys, function callback).

[lidel]

This is a very good feedback that cleared a lot! 👍 🔍
Thank you @rogersachan!

Different handling of manifest keys is inconvenient, but can be managed.
But the last error is a show-stopper.

It seems that Edge provides browser.* APIs as callback-only. On top of that presence of browser object prevents webextension-polyfil from being correctly applied. This is very unfortunate, they should either expose callback-only APIs under chrome.* namespace, or add promise support to browser.*.

There is an interesting discussion at mozilla/webextension-polyfill#3.
The upstream ticket at Microsoft about adding promise support was just reopened.

I am marking it as "blocked" until it is resolved upstream, either by Microsoft or Mozilla.

tl;dr

At the moment, neither a working polyfill, nor any other cross browser solution exists.
– mozilla/webextension-polyfill#3 (comment)

We hear the request for this support. Have reactivated this request, and added to our backlog.
– Microsoft Edge Team