fix(dnslink): skip URLs that could produce infinite recursion

lidel · lidel · commit 9eda0bf312f6 · 2017-10-10T22:38:14.000+02:00
More details: #286 (comment)
diff --git a/add-on/src/lib/common.js b/add-on/src/lib/common.js
@@ -224,8 +224,10 @@ function isDnslookupPossible () {
 }
 
 function isDnslookupSafeForURL (requestUrl) {
+  // skip URLs that could produce infinite recursion or weird loops
   return isDnslookupPossible() &&
     requestUrl.startsWith('http') &&
+    !window.IsIpfs.url(requestUrl) &&
     !requestUrl.startsWith(state.apiURLString) &&
     !requestUrl.startsWith(state.gwURLString)
 }

Original file line number	Diff line number	Diff line change
`@@ -224,8 +224,10 @@ function isDnslookupPossible () {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`function isDnslookupSafeForURL (requestUrl) {`
	`227`	`+ // skip URLs that could produce infinite recursion or weird loops`
`227`	`228`	`return isDnslookupPossible() &&`
`228`	`229`	`requestUrl.startsWith('http') &&`
	`230`	`+ !window.IsIpfs.url(requestUrl) &&`
`229`	`231`	`!requestUrl.startsWith(state.apiURLString) &&`
`230`	`232`	`!requestUrl.startsWith(state.gwURLString)`
`231`	`233`	`}`