Skip to content

Unbreak the mypy tests #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dokterbob opened this issue Mar 31, 2021 · 6 comments
Closed

Unbreak the mypy tests #255

dokterbob opened this issue Mar 31, 2021 · 6 comments

Comments

@dokterbob
Copy link
Contributor

Making it easier to make (for contributors) and accept (for maintainers) contributions.

@ntninja ntninja changed the title Unbreak the tests Unbreak the mypy tests Mar 31, 2021
@ntninja
Copy link
Contributor

ntninja commented Mar 31, 2021

mypy stuff breaks with like every second update, but it should be fixed again I agree.

@ntninja
Copy link
Contributor

ntninja commented Mar 31, 2021

Want to delay this until after 0.8 since it's likely a lot of work.

@c0llab0rat0r
Copy link
Contributor

Want to delay this until after 0.8 since it's likely a lot of work.

This will be significantly less work if the minimum Python version is raised to 3.7. #258

@c0llab0rat0r
Copy link
Contributor

If #257 and #260 are merged, it would resolve this issue.

@c0llab0rat0r
Copy link
Contributor

@ntninja with the merge of #261, I believe this is now resolved, though there is more work to do to remove type hint warning suppression.

@ntninja
Copy link
Contributor

ntninja commented Apr 9, 2021

Yes it can be better of course, but it a much better situation than what we started out with thanks to you!

@ntninja ntninja closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants